Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd Title Handling #480

Closed
jun6lee opened this issue Oct 6, 2020 · 12 comments
Closed

Odd Title Handling #480

jun6lee opened this issue Oct 6, 2020 · 12 comments
Assignees
Labels
enhancement New feature or request metadata quality issue Data out of our control is causing the issue

Comments

@jun6lee
Copy link

jun6lee commented Oct 6, 2020

https://comicvine.gamespot.com/hellboy-makoma-or-a-tale-told-by-a-mummy-in-the-ne/4050-18284/

Struggling to get the 2 issues of this recognised.
Could you guide if it's too odd a title or how I should name the files to be recognised?

Thus far, I've tried:

Hellboy Makoma or a Tale Told by a Mummy in the New York City Explorers Club on August 16 1993 - 01 (2006)
Hellboy Makoma or a Tale Told by a Mummy in the New York City Explorers Club - 01 (2006)
Hellboy Makoma - 01 (2006)

As an enhancement, it would be great if we could preview what Mylars post-processing would name a file.

evilhero added a commit that referenced this issue Oct 6, 2020
@evilhero
Copy link
Collaborator

evilhero commented Oct 6, 2020

The in the CV title itself was the problem - Mylar was not matching properly to those types of punctuation for some reason, or at least in this case it wasn't. Fix is in python3-dev branch now.

For it to match however, the title has to match exactly as to how CV has it - which would mean that your first example would match ( and does with the fix ), but the remaining 2 would not match at all.

Also it's impossible to preview what a file is like during post-processing since there is no GUI option to see what's being detected during post-processing, and honestly there never will be - that's far too much work for something of very little use overall. There is a Preview Renamer that is coming whereby you can view how renaming formatting is applied to files that are already downloaded, however it's only for items that are already in a Downloaded state.

@jun6lee
Copy link
Author

jun6lee commented Oct 6, 2020

That tool would still be great. I tend to download packs and then pick what I want in my library, so I can rename accordingly.
Found another title that I'm struggling with, this time with "

https://comicvine.gamespot.com/james-bond-in-reflections-of-death-1-ogn/4000-799856/

@evilhero
Copy link
Collaborator

evilhero commented Oct 6, 2020

Try setting the Alternate Search Name field in the Edit Settings tab for that series to something that doesn't include the " (ie. like James Bond in Reflections of Death).

The Alternate Search Name is used when you have filenames that are named differently than what CV has them as (as CV can have really f'd up naming, as is the case in this case), and it applies to all aspects of matching - so file checking, post-processing, searching.

You might also want to look at the Alternate File-Naming field on the Edit Settings tab as well. Whatever name is set here is how your files will be renamed to, ie. James Bond in Reflections of Death as by default, Mylar will take the series title from CV as the title in a renamed filename (if you have renaming enabled) - which would also then get past the " in the CV title aspect once it's been renamed.

Of course, if you just set the Alternate Search Name that would be good enough for Mylar to still see the file, just the file on your system would be possibly different (not too sure if it would actually write " in the filename itself).

I'll look into the " not being included in the comparisons.

@jun6lee
Copy link
Author

jun6lee commented Oct 6, 2020

Here's another messed up title:
https://comicvine.gamespot.com/god-is-dead-the-book-of-acts/4050-76270/

They've put # in the issue number and not even used numbers.

@evilhero
Copy link
Collaborator

evilhero commented Oct 7, 2020

The only way to handle the last one (where the issue numbering is #alpha and #omega for issues #1 and #2 respectively) is to actually use the pound sign to designate that it's an issue numbering (ie. #alpha, or #omega). Doing it this way will ensure that Mylar can detect the issues properly (and it does) as those are the actual issue numbers (and yes, other series have done this in the past).

@jun6lee
Copy link
Author

jun6lee commented Oct 10, 2020

I'm struggling with this last one. When I add the comic (not the files), it never seems to get out of the loop of refreshing.
ie; It doesn't know show any issues. Folder is created, but no cvinfo or cover.

I've tried manually putting in a cvinfo file and refreshing comic. No joy.

2020-10-10 23:39:07 ERROR [POST-PROCESSING] God Is Dead: The Book of Acts failed to update comic.
2020-10-10 23:39:07 INFO Now adding/updating issues for God Is Dead: The Book of Acts
2020-10-10 23:39:00 INFO Sucessfully retrieved issue details for God Is Dead: The Book of Acts

Appreciate the input above, but I've not got that far (yet, I think).

@evilhero
Copy link
Collaborator

cvinfo doesn't affect file rechecking - as it assumes everything in the given directory belongs to that specific series. The cvinfo file only matters during an import (at least for Mylar's use anyways).

Try putting mylar into debug mode (start it with the -v switch, or go into History, Logs, and then click on the Toggle Verbose Loggin ON option in the upper right). Once it's in debug mode, try the refresh again and paste / pastebin that in here - INFO level logging isn't enough to debug anything unfortunately.

@barbequesauce barbequesauce added enhancement New feature or request metadata quality issue Data out of our control is causing the issue labels Oct 12, 2020
@jun6lee
Copy link
Author

jun6lee commented Oct 13, 2020

Got it.

2020-10-13 20:48:07 ERROR Uncaught exception: Traceback (most recent call last):File "/share/CACHEDEV1_DATA/.qpkg/Mylar3/Mylar3/mylar/logger.py", line 337, in new_runold_run(*args, **kwargs)File "/opt/lib/python3.8/threading.py", line 870, in runFile "/share/CACHEDEV1_DATA/.qpkg/Mylar3/Mylar3/mylar/importer.py", line 371, in addComictoDBissuedata = updateddata['issuedata']TypeError: 'NoneType' object is not subscriptable
2020-10-13 20:48:07 DEBUG this does not have an issue # that I can parse properly.
2020-10-13 20:48:07 DEBUG [] invalid numeric for issue - cannot be found. Ignoring.
2020-10-13 20:48:07 INFO Now adding/updating issues for God Is Dead: The Book of Acts

@evilhero
Copy link
Collaborator

I'm guessing you're running the master branch of mylar3.

The fixes thus far that have been addressed are in the python3-dev branch atm, awaiting the merge to the master branch.

Also, if you're indicating about the last title, you need to precede both omega and alpha with a poundsign (ie. #omega or #alpha).

@jun6lee
Copy link
Author

jun6lee commented Oct 13, 2020

I can't change my branch. Qnap package seems to default master on startup.
I was referring to the last title though. You can probably replicate this easily enough.

Search: 4050-76270
Details of the comic appear, but not of the issues.
((Comic information is currently being loaded)) keeps looping.

https://i.imgur.com/VdaTdJz.png

This is before I try to import any issue.

@evilhero
Copy link
Collaborator

This has already been fixed in the python3-dev branch (#480) - which allows for Mylar to be able to interpret the issue naming of Omega and Alpha, which are the 2 issues in that particular series that is having problems.

You'll have to wait for the merge to master if you can't switch branches.

@jun6lee
Copy link
Author

jun6lee commented Oct 13, 2020

Sure thing, no problem. I'll wait it out. Not in a hurry. Thank you.

@jun6lee jun6lee closed this as completed Oct 13, 2020
evilhero added a commit that referenced this issue Oct 19, 2020
FIX:(#496) when parsing filenames (search / post-processing / refresh) would incorrectly parse some items in the filename as if they belonged to an issue exception listing

IMP: Updated parsing / polling CV to include LR issue numbering

IMP: Added global issue exceptions list so adding future alpha issue numbering is slightly easier

FIX: (as per a small portion of #476) Fixed incorrect qbittorrent initialization, and added initialization for TMP_PROV and EXT_IP globally

fixed setting the tools.sessions.timeout value

Fixed some janky css paths and js paths for webviewer

FIX:(#488) make sure to set/check the default value for dupe_constraint on startup

FIX:(#480) Allow for Omega and Alpha numbering

FIX:(#485) If padding was not enabled, would still try to padd some values incorrectly

FIX: fix for file parser not properly detecting filenames using _ as a space delmiter and also including a # sign to desginate an issue number

FIX: fix for search results icon not showing up regardless of interface used

FIX:(#480) CV titles that had a ’ instead of a ' would not match up properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metadata quality issue Data out of our control is causing the issue
Projects
None yet
Development

No branches or pull requests

3 participants