Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'zeroadd' referenced before assignment with Post-Processing #485

Closed
PCurd opened this issue Oct 9, 2020 · 3 comments
Closed

'zeroadd' referenced before assignment with Post-Processing #485

PCurd opened this issue Oct 9, 2020 · 3 comments

Comments

@PCurd
Copy link

PCurd commented Oct 9, 2020

Describe the bug
After starting a new Mylar3 docker and migrating parts of the config file from Mylar 2 over (SAB config, etc.), when loading comic files from disk in a manual post-process an error is received for many filenames - error received is:

Uncaught exception: Traceback (most recent call last):
File "/app/mylar/logger.py", line 337, in new_run
old_run(*args, **kwargs)
File "/usr/lib/python3.8/threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "/app/mylar/PostProcessor.py", line 1749, in Process
self.Process_next(comicid, issueid, issuenumOG, ml, stat)
File "/app/mylar/PostProcessor.py", line 2317, in Process_next
prettycomiss = str(zeroadd) + str(iss)
UnboundLocalError: local variable 'zeroadd' referenced before assignment

Full error:

2020-10-09 16:17:23 | ERROR | Uncaught exception: Traceback (most recent call last):File "/app/mylar/logger.py", line 337, in new_runold_run(*args, **kwargs)File "/usr/lib/python3.8/threading.py", line 870, in runself._target(*self._args, **self._kwargs)File "/app/mylar/PostProcessor.py", line 1749, in Processself.Process_next(comicid, issueid, issuenumOG, ml, stat)File "/app/mylar/PostProcessor.py", line 2317, in Process_nextprettycomiss = str(zeroadd) + str(iss)UnboundLocalError: local variable 'zeroadd' referenced before assignment
-- | -- | --
2020-10-09 16:17:23 | DEBUG | issue detected less than 10
2020-10-09 16:17:23 | DEBUG | [POST-PROCESSING] Zero Suppression set to : None
2020-10-09 16:17:23 | DEBUG | [POST-PROCESSING] issuenumOG: 2
2020-10-09 16:17:23 | DEBUG | [POST-PROCESSING] issueid: 797888
2020-10-09 16:17:23 | INFO | [POST-PROCESSING] [1/7] Starting Post-Processing for Fishkill issue: 2
2020-10-09 16:17:23 | INFO | [DUPECHECK] Duplication detection returned no hits. This is not a duplicate of anything that I have scanned in as of yet.
2020-10-09 16:17:23 | INFO | [DUPECHECK] Duplicate check for /downloads/comics-manual/Fishkill.002.2020.digital.Son.of.Ultron-Empire/Fishkill 002 (2020) (digital) (Son of Ultron-Empire).cbr

CarePackage

carepackage.zip

Environment (please complete the following information):

  • OS: Unraid (Docker)
  • Branch / commit: Mylar Version: master [v0.4.6 - Reality is broken... and I'm the repairman!]
    -- source (build eb7188e)

Additional information
I was able to load a file without issue numbers successfully. The zero level configuration is the same as my Mylar 2 install:

zero_level = False
zero_level_n = None
evilhero added a commit that referenced this issue Oct 9, 2020
@evilhero
FIX:(#485) If padding was not enabled, would still try to padd some v…
9133e20 
…alues incorrectly
barbequesauce pushed a commit that referenced this issue Oct 9, 2020
@evilhero @barbequesauce
FIX:(#485) If padding was not enabled, would still try to padd some v…
67788f1 
…alues incorrectly
@PCurd
Copy link
Author

PCurd commented Oct 12, 2020

Using the nightly docker build (Python3-dev branch) the files import fine now.

@PCurd PCurd closed this as completed Oct 12, 2020
@barbequesauce
Copy link
Collaborator

are we ok to close this issue?

@PCurd
Copy link
Author

PCurd commented Oct 14, 2020

I thought I already had closed it, do I need to do an extra step?

evilhero added a commit that referenced this issue Oct 19, 2020
@evilhero
python3-dev merge
91fad59 
FIX:(#496) when parsing filenames (search / post-processing / refresh) would incorrectly parse some items in the filename as if they belonged to an issue exception listing

IMP: Updated parsing / polling CV to include LR issue numbering

IMP: Added global issue exceptions list so adding future alpha issue numbering is slightly easier

FIX: (as per a small portion of #476) Fixed incorrect qbittorrent initialization, and added initialization for TMP_PROV and EXT_IP globally

fixed setting the tools.sessions.timeout value

Fixed some janky css paths and js paths for webviewer

FIX:(#488) make sure to set/check the default value for dupe_constraint on startup

FIX:(#480) Allow for Omega and Alpha numbering

FIX:(#485) If padding was not enabled, would still try to padd some values incorrectly

FIX: fix for file parser not properly detecting filenames using _ as a space delmiter and also including a # sign to desginate an issue number

FIX: fix for search results icon not showing up regardless of interface used

FIX:(#480) CV titles that had a ’ instead of a ' would not match up properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PCurd @barbequesauce