Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website doesn't open from program #551

Closed
zb13y opened this issue Jan 7, 2016 · 18 comments
Closed

Website doesn't open from program #551

zb13y opened this issue Jan 7, 2016 · 18 comments
Labels
platform.Windows Issue is reported on Windows solution.Upstream It's a bug, but not ours

Comments

@zb13y
Copy link

zb13y commented Jan 7, 2016

Help - About MyPaint - Website

Could not show link
Failed to execute helper program (invalid argument)

I can open online help.

Beta 4 x64, Windows 10 x64.

@tumagonx
Copy link
Contributor

tumagonx commented Jan 7, 2016

This work my build using gtk 3.14.15 (opening IE to http://mypaint.org/), maybe this still related to #531 ? in this case protocol association.

@zb13y does it works with beta1?

@zb13y
Copy link
Author

zb13y commented Jan 7, 2016

Yes, its work in beta 1.

@tumagonx tumagonx added platform.Windows Issue is reported on Windows solution.Upstream It's a bug, but not ours labels Jan 7, 2016
@achadwick
Copy link
Member

Is the the HCY wheel's help button broken too?

@zb13y
Copy link
Author

zb13y commented Jan 7, 2016

Yes, broken too. No reaction, in debug mode i have this message:

(python2.exe:6008): Gtk-WARNING **: Unable to show 'https://github.com/mypaint/mypaint/wiki/v1.2-HCY-Wheel-and-Gamut-Mask-Editor': ═х єфрыюё№ т√яюыэшЄ№ тёяюьюурЄхы№эє■ яЁюуЁрььє (Invalid argument)

@tumagonx
Copy link
Contributor

tumagonx commented Jan 7, 2016

ugh, why it looks like that? Now I'm unsure if this share the same culprit as #531, but still is upstream issue.

@tumagonx
Copy link
Contributor

tumagonx commented Jan 7, 2016

sorry, took me a while to realize if that was cyrillic message

@tumagonx
Copy link
Contributor

tumagonx commented Jan 7, 2016

Hmm I can't reproduce this with gtk3-demo 3.18.6 > Links > click on the google hyperlink
It works fine! But again is it the same thing? (text markup feature that trigger url association)

used glib: 2.46.2

@achadwick
Copy link
Member

The ones that are working from the MyPaint UI use the Python webbrowser module. Can't really use that type of workaround this time, but at least it isn't segfaulting ☺

@danpla
Copy link
Contributor

danpla commented Apr 15, 2016

Maybe because gspawn-win[32|64]-helper-console.exe (or gspawn-win[32|64]-helper.exe, or both of them) is missing in distributions.

@achadwick achadwick added this to the MyPaint v1.3.0 milestone Apr 15, 2016
@achadwick
Copy link
Member

@danpla thanks for the hint. We can bundle those too.

@tumagonx
Copy link
Contributor

@danpla Did you reproduce it in 1.2.0 release? It works fine here.

Windows mechanism itself don't need custom launcher (like gspawn) to
just launch associated apps. Gspawn used when glib need fine-grained
control over its child process which is not the case here. This bug is
directly related to glib regression in registry association.

Personally I take care what needed and whatnot, I'm quite picky at
this. Sure for practical reason (since they are small) it can be
bundled, no problem.

On 4/16/16, Andrew Chadwick notifications@github.com wrote:

@danpla thanks for the hint. We can bundle those too.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#551 (comment)

!tuma

@danpla
Copy link
Contributor

danpla commented Apr 16, 2016

@tumagonx Yes, links work in 1.2.0, but not in the recent 1.2.1-beta.0 testing builds.

For the 64 bit test build, copying gspawn from my MSYS2 installation solved the problem. The "console" version of the gspawn needed for python2.exe, the "normal" one - for python2w.exe.

However, it is not possible to test the 32-bit build, because the current 32-bit glib from MSYS2 is somewhat broken: after clicking on a link, it always crashes an app (MyPaint or mingw32\bin\gtk-demo.exe) with with this assertion:

Warning: unquote_string_inplace: assertion 'err == NULL || *err == NULL' failed

I don't know about GTK internals, but I can assume that gspawn dependency can be controlled by compile-time flags used to build glib/gtk for Windows.

The reason why I'm remember gspawn is that I had some experience of packing GTK+ apps for Windows, and I had exactly the same problem, which was solved by including it. However, I used Python 3 with PyGObject for Windows and cx_Freeze.

@tumagonx
Copy link
Contributor

That's why I asked your confirmation with 1.2.0 : ) which don't have
gspawner for both 32/64bit
AFAIK unless your app use dbus there is no need for it.

After I checked it again glib starting with 2.46 changed from using
ShellExecuteExW (win32 api) to gspawn (see gwin32appinfo,c). So you're
right things has changed. :D

On 4/16/16, Daniel Plachotich notifications@github.com wrote:

@tumagonx Yes, links work in 1.2.0, but not in the recent 1.2.1-beta.0
testing builds.

For the 64 bit test build, copying gspawn from my MSYS2 installation solved
the problem. The "console" version of gspawn needed for python2.exe, the
"normal" one - for python2w.exe.

However, it is not possible to test the 32-bit build, because the current
32-bit glib from MSYS2 is somewhat broken: after clicking on a link, it
always crashes an app (MyPaint or mingw32\bin\gtk-demo.exe) with with this
assertion:

Warning: unquote_string_inplace: assertion 'err == NULL || *err == NULL'
failed

I don't know about GTK internals, but I can assume that gspawn dependency
can be controlled by compile-time flags used to build glib/gtk for Windows.

The reason why I'm remember gspawn is that I had some experience of packing
GTK+ apps for Windows, and I had exactly the same problem, which was solved
by including it. However, I used Python 3 with PyGObject for
Windows
and cx_Freeze.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#551 (comment)

!tuma

@tumagonx
Copy link
Contributor

gspawn is mandatory part glib, it just that i'm picky at removing
unused stuff (which is true for glib 2.44). It happened that both me
and achadwick don't include gspawn and so I thought it was another
upstream regression. duh

OT btw i'm maintainer of https://sourceforge.net/projects/pygobjectwin32

On 4/16/16, Bakhtiar Hasmanan mr.tiar@gmail.com wrote:

That's why I asked your confirmation with 1.2.0 : ) which don't have
gspawner for both 32/64bit
AFAIK unless your app use dbus there is no need for it.

After I checked it again glib starting with 2.46 changed from using
ShellExecuteExW (win32 api) to gspawn (see gwin32appinfo,c). So you're
right things has changed. :D

On 4/16/16, Daniel Plachotich notifications@github.com wrote:

@tumagonx Yes, links work in 1.2.0, but not in the recent 1.2.1-beta.0
testing builds.

For the 64 bit test build, copying gspawn from my MSYS2 installation
solved
the problem. The "console" version of gspawn needed for python2.exe,
the
"normal" one - for python2w.exe.

However, it is not possible to test the 32-bit build, because the current
32-bit glib from MSYS2 is somewhat broken: after clicking on a link, it
always crashes an app (MyPaint or mingw32\bin\gtk-demo.exe) with with
this
assertion:

Warning: unquote_string_inplace: assertion 'err == NULL || *err == NULL'
failed

I don't know about GTK internals, but I can assume that gspawn dependency
can be controlled by compile-time flags used to build glib/gtk for
Windows.

The reason why I'm remember gspawn is that I had some experience of
packing
GTK+ apps for Windows, and I had exactly the same problem, which was
solved
by including it. However, I used Python 3 with PyGObject for
Windows
and cx_Freeze.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#551 (comment)

!tuma

!tuma

@achadwick
Copy link
Member

MyPaint v1.2.1 has been released. Please can you try it out and see if this bug is still happening?

The current stable MyPaint build has a deletion exclusion mingw*/bin/gspawn-*-helper.exe according to my styrene config file 😄

@zb13y
Copy link
Author

zb13y commented Jan 24, 2017

1.2.1+gitexport.bcf5a28d (Python 2.7.13, GTK 3.22.7, GdkPixbuf 2.36.4, Cairo 1.15.4, GLib 2.50.1)

Still can't open website.

@zb13y
Copy link
Author

zb13y commented Jan 25, 2017

Oops! Sorry, it works. My browser (self-protection, like HIPS) was blocking mypaint.

@zb13y zb13y closed this as completed Jan 25, 2017
@achadwick
Copy link
Member

Confirmed that it's working with mine too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform.Windows Issue is reported on Windows solution.Upstream It's a bug, but not ours
Development

No branches or pull requests

4 participants