Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consignment): make email nullable #373

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

RichardPerdaan
Copy link
Member

No description provided.

@RichardPerdaan RichardPerdaan requested a review from a team as a code owner December 30, 2021 12:46
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #373 (e07bb63) into develop (5c3d7e2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #373   +/-   ##
==========================================
  Coverage      42.23%   42.23%           
- Complexity      1632     1634    +2     
==========================================
  Files             93       93           
  Lines           4039     4039           
==========================================
  Hits            1706     1706           
  Misses          2333     2333           
Impacted Files Coverage Δ
src/Model/Consignment/AbstractConsignment.php 70.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c3d7e2...e07bb63. Read the comment docs.

@RichardPerdaan RichardPerdaan changed the title fix: fix the possibility that email may be null feat(consignment): make email nullable Dec 30, 2021
@RichardPerdaan RichardPerdaan merged commit cafc77b into develop Dec 30, 2021
@RichardPerdaan RichardPerdaan deleted the fix-email-can-be-null branch December 30, 2021 12:52
EdieLemoine pushed a commit that referenced this pull request Dec 31, 2021
* feat(consignment): make email nullable
EdieLemoine pushed a commit that referenced this pull request Dec 31, 2021
* feat(consignment): make email nullable
EdieLemoine pushed a commit that referenced this pull request Dec 31, 2021
* feat(consignment): make email nullable
github-actions bot pushed a commit that referenced this pull request Dec 31, 2021
## [6.1.0](v6.0.0...v6.1.0) (2021-12-31)

### 🐛 Bug Fixes

* **consignment:** only validate delivery date if needed ([#364](#364)) ([2f34c53](2f34c53))
* **pps:** export delivery options ([#360](#360)) ([c333346](c333346))
* **pps:** export order date with a timestamp ([09eca9c](09eca9c))
* **pps:** export Rest of World orders ([#358](#358)) ([97da682](97da682))

### ✨ New Features

* **consignment:** make email nullable ([#373](#373)) ([867b54a](867b54a))
* **pps:** allow setting of label description ([289d0d1](289d0d1))
* **recipient:** add region property ([#367](#367)) ([32a1d38](32a1d38))
* **recipient:** add setFullStreet ([#349](#349)) ([9f40418](9f40418))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants