Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product): support variation product settings #996

Merged
merged 18 commits into from
Aug 9, 2023

Conversation

joerivanveen
Copy link
Contributor

@joerivanveen joerivanveen commented Aug 1, 2023

@EdieLemoine EdieLemoine force-pushed the feat/support-variation-product-settings branch from d6a243c to ff1d40f Compare August 3, 2023 09:05
@joerivanveen joerivanveen changed the base branch from alpha to beta August 8, 2023 12:15
@joerivanveen joerivanveen marked this pull request as ready for review August 8, 2023 12:22
@joerivanveen joerivanveen requested a review from a team as a code owner August 8, 2023 12:22
src/Pdk/Hooks/PdkProductSettingsHooks.php Show resolved Hide resolved
src/Pdk/Service/WcViewService.php Outdated Show resolved Hide resolved
src/Pdk/Service/WcFrontendRenderService.php Outdated Show resolved Hide resolved
src/Pdk/Product/Repository/WcPdkProductRepository.php Outdated Show resolved Hide resolved
src/Pdk/Hooks/PdkProductSettingsHooks.php Outdated Show resolved Hide resolved
src/Pdk/Hooks/PdkProductSettingsHooks.php Outdated Show resolved Hide resolved
@EdieLemoine EdieLemoine force-pushed the feat/support-variation-product-settings branch from 7bcb38c to c00f6e4 Compare August 8, 2023 13:40
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #996 (3d12911) into beta (4ffffbe) will increase coverage by 1.45%.
The diff coverage is 75.40%.

@@             Coverage Diff              @@
##               beta     #996      +/-   ##
============================================
+ Coverage     52.34%   53.79%   +1.45%     
- Complexity      476      482       +6     
============================================
  Files           118      123       +5     
  Lines          4140     4264     +124     
  Branches         20       19       -1     
============================================
+ Hits           2167     2294     +127     
+ Misses         1953     1951       -2     
+ Partials         20       19       -1     
Flag Coverage Δ
admin 82.58% <81.16%> (+2.34%) ⬆️
backend 39.89% <48.48%> (-0.09%) ⬇️
checkout 0.00% <ø> (ø)
frontend 73.38% <81.16%> (+2.65%) ⬆️
unit 53.79% <75.40%> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Pdk/Service/WcFrontendRenderService.php 0.00% <0.00%> (ø)
src/Pdk/Service/WcViewService.php 0.00% <0.00%> (ø)
views/backend/admin/src/initialize.ts 0.00% <0.00%> (ø)
...ws/backend/admin/src/composables/useElementData.ts 28.57% <28.57%> (ø)
src/Pdk/Hooks/PdkProductSettingsHooks.php 34.42% <45.83%> (-6.00%) ⬇️
.../Pdk/Product/Repository/WcPdkProductRepository.php 95.74% <100.00%> (+0.29%) ⬆️
...ews/backend/admin/src/components/WcDescription.vue 100.00% <100.00%> (ø)
views/backend/admin/src/components/WcHelpTip.vue 100.00% <100.00%> (ø)
...components/pdk/WcChildProductSettingsFormGroup.vue 100.00% <100.00%> (ø)
...s/backend/admin/src/components/pdk/WcFormGroup.vue 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joerivanveen joerivanveen force-pushed the feat/support-variation-product-settings branch 2 times, most recently from 3f4a8d7 to 50315b7 Compare August 9, 2023 08:17
@myparcel-bot myparcel-bot bot force-pushed the feat/support-variation-product-settings branch from 50315b7 to 2fe85c5 Compare August 9, 2023 08:33
@myparcel-bot myparcel-bot bot force-pushed the feat/support-variation-product-settings branch from 2fe85c5 to 7bf1d15 Compare August 9, 2023 08:37
@EdieLemoine EdieLemoine changed the title feat: support variation product settings feat(product): support variation product settings Aug 9, 2023
- upgrade @myparcel-pdk/admin-component-tests to v1.0.0-alpha.100
- upgrade @myparcel-pdk/admin-preset-dashicons to v1.0.0-alpha.98
- upgrade @myparcel-pdk/admin-preset-default to v1.0.0-alpha.96
- upgrade @myparcel-pdk/admin to v1.0.0-alpha.97
- upgrade @myparcel-pdk/frontend-admin-core to v1.0.0-alpha.97
@EdieLemoine EdieLemoine enabled auto-merge (squash) August 9, 2023 12:07
@EdieLemoine EdieLemoine merged commit 9ae405b into beta Aug 9, 2023
4 of 5 checks passed
@EdieLemoine EdieLemoine deleted the feat/support-variation-product-settings branch August 9, 2023 12:09
EdieLemoine added a commit that referenced this pull request Aug 10, 2023
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
EdieLemoine added a commit that referenced this pull request Aug 22, 2023
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
joerivanveen added a commit that referenced this pull request Aug 22, 2023
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
Mark-Ernst pushed a commit that referenced this pull request Aug 23, 2023
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
joerivanveen added a commit that referenced this pull request Aug 29, 2023
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
joerivanveen added a commit that referenced this pull request Aug 29, 2023
Co-authored-by: Edie Lemoine <edie@myparcel.nl>
myparcel-bot bot added a commit that referenced this pull request Sep 29, 2023
## 🚧 This version is not ready for production use 🚧

This is the beta release of MyParcel WooCommerce v5.x. We've rewritten the entire plugin from scratch, using the [MyParcel Plugin Development Kit].

For a less bug-prone experience, we recommend you use the stable or release candidate versions of the plugin instead. You can find the stable version in the [WordPress plugin directory]. The release candidate versions can be found in the [releases] section of this repository. They are versioned with a `-rc` suffix.

If you do choose to install this version, we would love to hear your feedback. Please report any issues you encounter using the [Bug report for v5.0.0-beta.x form] or by sending an email to [support@myparcel.nl]. Use it in production at your own risk.

[Bug report for v5.0.0-beta.x form]: https://github.com/myparcelnl/woocommerce/issues/new?labels=beta&template=ZZ-BUG-REPORT-v5.yml
[MyParcel Plugin Development Kit]: https://developer.myparcel.nl/documentation/52.pdk/
[WordPress plugin directory]: https://wordpress.org/plugins/woocommerce-myparcel/
[releases]: https://github.com/myparcelnl/woocommerce/releases
[support@myparcel.nl]: mailto:support@myparcel.nl

## [5.0.0-beta.1](v4.19.1...v5.0.0-beta.1) (2023-09-29)

### ⚠ BREAKING CHANGES

* rebuild entire plugin with pdk

### ⚡ Performance Improvements

* reduce amount of checks for account ([9b83be8](9b83be8))

### 🐛 Bug Fixes

* add missing entry to container ([f4cb71b](f4cb71b))
* **admin:** add missing animations ([132da45](132da45))
* **admin:** add multi select input ([20e71a5](20e71a5))
* **admin:** change shipment label row transition ([c2d7cad](c2d7cad))
* **admin:** do not render untranslated subtext ([fb0ccce](fb0ccce))
* **admin:** fix code editor not being used ([60f6014](60f6014))
* **admin:** fix console warning on modal open ([8040268](8040268))
* **admin:** fix cutoff time option throwing error ([8e84af9](8e84af9))
* **admin:** fix cutoff time translation ([87faab8](87faab8))
* **admin:** fix disabled and readonly logic on all inputs ([77a5492](77a5492))
* **admin:** fix import of shipment label wrapper ([69dc9fa](69dc9fa))
* **admin:** fix input widths exceeding containers ([e3381db](e3381db))
* **admin:** fix label description notice in order grid ([63b631e](63b631e))
* **admin:** fix rendering on elements with undefined as ref value ([5332974](5332974))
* **admin:** fix select boxes duplicating and options not being preselected ([2afaf62](2afaf62))
* **admin:** fix select inputs not showing initial value ([85ceb13](85ceb13))
* **admin:** fix tooltips not being initialized ([43cfc49](43cfc49))
* **admin:** improve accessibility ([be58218](be58218))
* **admin:** improve dropdown button ([578dadb](578dadb))
* **admin:** improve select inputs ([7aab3b1](7aab3b1))
* **admin:** initialize tooltips properly ([2f46db0](2f46db0))
* **admin:** make button groups responsive ([#1003](#1003)) ([654b8b9](654b8b9))
* **admin:** make the boxes and modals match wordpress better ([#1001](#1001)) ([e95b663](e95b663))
* **admin:** translate form group text correctly ([e0ba9c0](e0ba9c0))
* **admin:** update button style ([184b4b4](184b4b4))
* **admin:** update components ([ba5f874](ba5f874))
* **admin:** update form group ([8a2e5ee](8a2e5ee))
* **admin:** use different log level in production mode ([d2538f0](d2538f0))
* **admin:** use the correct versions of js dependencies ([2eefa0e](2eefa0e))
* **build:** fix plugin not being seen as new version of 4.x ([f832abb](f832abb))
* **cart:** fix incorrect reference to delivery options fees service ([27b0776](27b0776))
* **checkout:** disable eori field warnings when they don't exist ([adc7527](adc7527))
* **checkout:** fix delivery options not being passed to backend ([33288e8](33288e8))
* **checkout:** fix delivery options not being saved to order ([e69766e](e69766e))
* **checkout:** fix empty billing address 1 ([#1005](#1005)) ([b6ac3cc](b6ac3cc))
* **checkout:** fix error on submitting order ([dae7a45](dae7a45))
* **checkout:** fix javascript error on order received page ([c0477cc](c0477cc))
* **checkout:** fix third party shipping methods not working with delivery options ([80357fc](80357fc))
* **checkout:** improve checkout logic ([26e3ee1](26e3ee1))
* **checkout:** prevent orders without incomplete address ([e416558](e416558))
* **components:** improve components ([942f0f3](942f0f3))
* correctly show track & trace in account page ([ecb4fd8](ecb4fd8))
* **customs-declaration:** pass correct package contents ([#1012](#1012)) ([dde84e6](dde84e6))
* **customs-declarations:** fix items amount ([#1010](#1010)) ([545a8f1](545a8f1))
* disable plugin peacefully when prerequisites are not met ([d891414](d891414))
* disable selectwoo for now because it won't work ([d20972e](d20972e))
* do not show product settings in custom fields ([c21f951](c21f951))
* ensure numeric values at physical properties ([44e96f8](44e96f8))
* **export:** export label description ([ced065d](ced065d))
* fill settings that didnt't exist before migration ([bab3a36](bab3a36))
* **filters:** allow not having a default value ([c580358](c580358))
* fix changes in settings and account not being updated correctly ([514d990](514d990))
* fix custom fields not showing when they should ([8b1a3e1](8b1a3e1))
* fix imports ([d8a49ce](d8a49ce))
* fix naming error in bulk actions order mode ([4a7c17b](4a7c17b))
* fix number error on "add order" page ([adadd92](adadd92))
* fix undefined index warning ([7b82dd4](7b82dd4))
* fix width of carrier settings not matching other tabs ([#1000](#1000)) ([2f52c19](2f52c19))
* **hooks:** fix error on getting pdk frontend routes ([e0973e8](e0973e8))
* **hpos:** fix order grid bulk actions not working ([d1eef35](d1eef35))
* implement bootstrapper ([26feee5](26feee5))
* improve components ([3a276a9](3a276a9))
* improve prerequisites logic ([60b65f7](60b65f7))
* increase order list column width ([73b8980](73b8980))
* **meta:** fix settings link not showing on plugins page ([1ea10bc](1ea10bc))
* **migration:** fix allow pickup locations setting not being migrated ([44e29d1](44e29d1))
* **migration:** fix existing settings ([e7f6d11](e7f6d11))
* **migration:** fix inverted product settings search query ([e76028e](e76028e))
* **migration:** fix product settings migration failing ([2c32dd7](2c32dd7))
* **migration:** have weightservice work with all units ([f6e2614](f6e2614))
* **migration:** improve migration logic ([5364a02](5364a02))
* **migration:** improve migrations ([e340e9d](e340e9d))
* **migration:** improve order migration ([bb8e7ef](bb8e7ef))
* **migration:** improve pdk migrations ([a970919](a970919))
* **migration:** improve settings migration ([43e0c69](43e0c69))
* **migration:** improve shipping methods migration ([b9383d3](b9383d3))
* **migration:** migrate shipments to proper address fields ([f5db010](f5db010))
* **migration:** set delivery options date to null if it's empty ([#1020](#1020)) ([58fc7a0](58fc7a0))
* **migration:** transform existing carrier settings ([7a9788b](7a9788b))
* **modal:** fix modal actions ([840f4ad](840f4ad))
* **notes:** get api identifier from order meta data ([91d87b3](91d87b3))
* **orders:** convert weight to grams ([#1021](#1021)) ([bd38290](bd38290))
* **orders:** do not add return barcodes to order notes ([#998](#998)) ([34ca572](34ca572))
* **orders:** fix error when getting order via non-object ([0d39b5c](0d39b5c))
* **orders:** fix meta keys being saved multiple times ([98a4a3e](98a4a3e))
* **orders:** fix some errors when creating orders ([de47001](de47001))
* **orders:** fix state and missing address fields errors ([#1019](#1019)) ([8ef3e53](8ef3e53))
* **orders:** fix type error when country is missing ([f016b91](f016b91))
* **orders:** improve order note author mapping ([03e0a75](03e0a75))
* **plugin:** fix plugin being deactivated on upgrade ([3be182a](3be182a))
* prefix bulk actions with "MyParcel" ([#999](#999)) ([011376f](011376f))
* prevent array to string conversion warning ([90c587d](90c587d))
* **product:** fix product settings not working ([756369e](756369e))
* render settings page ([14e449d](14e449d))
* **request:** pass $_COOKIE and $_SERVER to converted requests ([0861ba3](0861ba3))
* **requests:** send correct user agent to myparcel api ([12e6afb](12e6afb))
* **request:** update guzzle adapter ([02cd681](02cd681))
* save shipment even when updated is not null ([e1e1849](e1e1849))
* set label description on order ([f7593f3](f7593f3))
* set physical properties on pdkorder ([9056140](9056140))
* **settings:** correct keys for webhook settings ([902d7d5](902d7d5))
* **settings:** fix correct shipping methods not showing up ([1528585](1528585))
* **settings:** make drop off toggle reactive again ([#1008](#1008)) ([ecb0cf0](ecb0cf0))
* **settings:** prevent array to string conversion notice ([16227b1](16227b1))
* show notices through all_admin_notices hook ([613fb73](613fb73))
* update account settings after migration ([c4cffdd](c4cffdd))
* update fields ([1180fdf](1180fdf))
* update frontend routes ([67b5aa1](67b5aa1))
* update product settings ([f1f2fa3](f1f2fa3))
* use correct option for automatic export ([4cc4959](4cc4959))
* wrap pdk admin init in window.onload ([899d14d](899d14d))

### ✨ New Features

* **account:** show delivery options in account ([9d515ad](9d515ad))
* add bulk actions ([c2ba715](c2ba715))
* add dhleuroplus and dhlparcelconnect ([643d297](643d297))
* **admin:** add subtext option to field ([5190f08](5190f08))
* **admin:** add text area and code editor component ([5adf95e](5adf95e))
* **admin:** improve button styles ([ba59c53](ba59c53))
* **admin:** improve radio component ([7d1faf3](7d1faf3))
* **admin:** make select2 component work properly ([a42cadf](a42cadf))
* **admin:** use native pdk product settings view ([da3b936](da3b936))
* **checkout:** improve checkout logic ([cdfd72a](cdfd72a))
* **deps:** update [@myparcel-pdk](https://github.com/myparcel-pdk) packages ([82986b9](82986b9))
* **deps:** update @myparcel-pdk/admin ([4b19ca2](4b19ca2))
* **deps:** update myparcelnl/pdk from 2.4.1 to 2.5.2 ([f09fabb](f09fabb))
* **deps:** update myparcelnl/pdk to from 2.3.0 to 2.4.1 ([a9e294e](a9e294e)), closes [#98](#98) [#105](#105)
* **deps:** update myparcelnl/pdk to v2.6.2 ([c9d367f](c9d367f))
* **deps:** upgrade @myparcel-pdk/* ([012f0dc](012f0dc))
* **deps:** upgrade myparcelnl/pdk to v2.19.0 ([a305f11](a305f11))
* **deps:** upgrade myparcelnl/pdk to v2.25.2 ([42b3fb0](42b3fb0))
* **deps:** upgrade myparcelnl/pdk to v2.8.0 ([0c6385e](0c6385e))
* **dhl:** add vat and eori fields for europlus ([#974](#974)) ([0517dac](0517dac))
* **endpoints:** improve endpoint logic ([6e24a68](6e24a68))
* **migration:** add package type to product settings ([#1006](#1006)) ([847552a](847552a))
* move frontend checkout logic to pdk ([d64e053](d64e053))
* move showing/hiding logic to app config ([4fc8a25](4fc8a25))
* **notes:** add hook to post note after adding to order ([0588f17](0588f17))
* **order:** get order notes ([a009cf7](a009cf7))
* **orders:** change order status on label print ([#1016](#1016)) ([fa5f5b6](fa5f5b6))
* **plugin:** add links to plugin meta ([7065195](7065195))
* prepend order note with text from settings ([68f6fe2](68f6fe2))
* **product:** support variation product settings ([#996](#996)) ([d4ae5b3](d4ae5b3))
* rebuild entire plugin with pdk ([bbab1af](bbab1af))
* retrieve shipping methods ([cd5f5d3](cd5f5d3))
* **settings:** improve settings views ([106f09c](106f09c))
* **shipments:** add barcode as order note ([#1004](#1004)) ([7155cb8](7155cb8))
* support woocommerce hpos ([74c9ccf](74c9ccf))
* **translations:** migrate to pdk builder translation logic ([542f25c](542f25c))
* update dependencies ([d13568d](d13568d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants