Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme from new design #27

Closed
crowbot opened this issue Oct 25, 2016 · 9 comments
Closed

Update theme from new design #27

crowbot opened this issue Oct 25, 2016 · 9 comments
Assignees

Comments

@crowbot
Copy link
Member

crowbot commented Oct 25, 2016

Designs in https://invis.io/2880QJIJH, resources in https://groups.google.com/a/mysociety.org/forum/?hl=en-GB#!topic/alaveteli/wJAp1GPuXcw

@garethrees
Copy link
Member

Just as a reminder, some of the changes in #24 might be useful here too.

@wrightmartin
Copy link
Contributor

A couple of notes on the designs and what I've implemented

  • I don’t want to move search bar and add social links becuase that change is coming in a core alaveteli update shortly - adding it now would mean IPV won’t get the change later
  • Changing the display of the requests in the lists (into big green boxes) has loads of knock-on affects because the code is everywhere - and will take a long time to implement and ensure nothing breaks/everything looks okay. For now the requests only look like that on the homepage

@crowbot
Copy link
Member Author

crowbot commented Nov 29, 2016

I don’t want to move search bar and add social links becuase that change is coming in a core alaveteli update shortly - adding it now would mean IPV won’t get the change later

Yep, I think that's OK to explain. Can you screenshot what's coming down the line in core for Richard and co so they can compare?

Changing the display of the requests in the lists (into big green boxes) has loads of knock-on affects because the code is everywhere - and will take a long time to implement and ensure nothing breaks/everything looks okay. For now the requests only look like that on the homepage

Fine to push back on this I think.

@wrightmartin
Copy link
Contributor

Ok, all done in #28

Ready to show Richard and his team at your leisure

@wrightmartin
Copy link
Contributor

wrightmartin commented Feb 10, 2017

  • Add Alaveteli as a partner, remove Otevrete
  • Make the system message less luminous green
  • Reduce vertical spacing on the homepage
  • The background white is whiter on the original design
  • Make a request page: the title isn't part of the form
  • Preview request page: the cancel button should be grey
  • Browse requests page: The filters don't look like the design
  • Browse authorities: The left hand side isn't like the designs, add grey boxes
  • User profile page: Not happy with how it looks
  • Force login: Would prefer a redirect to login page
  • Different homepage for logged-in users
  • Re-add home link in main nav

@wrightmartin
Copy link
Contributor

wrightmartin commented Feb 10, 2017

I've done the above in #28, except the following

User profile page: Not happy with how it looks

This is Alaveteli's core user profile page, it's on the roadmap to be improved. I'm not sure we should customise this one and make it miss out on any improvement that core gets.

Browse requests page: The filters don't look like the design

This is part of the core design and functionality - true, it doesn't look the same, but it does behave as expected.

The background white is whiter on the original design

I can't see this - perhaps it's a photoshop vs web browser difference? The white in the web version is the same as far as I can tell

@wrightmartin
Copy link
Contributor

Make a request page: the title isn't part of the form

To do this we'd need to customise the whole 'make a request' form - it would mean it won't get any upgrades from changes coming with pro

@garethrees
Copy link
Member

Force login: Would prefer a redirect to login page

We can't really change how this works. We do recommend using the default behaviour of presenting the login/registration form just before sending the request, rather before they start.

Different homepage for logged-in users

This isn't something that Alaveteli supports, so we can't do much about this. We're trialling a "dashboard" page for logged in pro users, which may well end up getting used for all users in the future.

@garethrees
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants