-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import script for NHS England CCG areas #192
Conversation
I realise this copies the previous PR you mention, but is there a reason this command isn't a subclass of the mapit_import Command? I can't obviously see a reason why it has to use call_command and duplicate a lot of options/set up code, but I may well have missed something. |
Commits have been tidied as requested. I'll have a go at refactoring this based on your suggestions and get back to you with an updated pull request. |
I've refactored this to extend mapit_import, as requested. I've constructed an appropriate option_list by slicing mapit_import's option_list tuple. This solution is more succinct then redefining it but the downside to this is that adding or removing elements from the start or in the middle of mapit_import's option_list tuple would require updating the line:
accordingly. |
Thanks, that's a bit less code :) A suggestion for your downside - see how what I've done in 3175d64 uses |
No problem - updated as requested. |
f8a2f78
to
bcb87c5
Compare
I think this is outdated as the current CCG boundary files can be imported with the generic import command. |
Agreed 👍 Closing this and tidying up some other forgotten PRs that went nowhere |
As with the Police Force boundaries (see pull request #73), NHS CCG boundaries for England are available as open data, but they aren't formatted in such a way that they import nicely into MapIt.
This import script solves that problem, importing the CCG boundaries cleanly.
This may be useful to pull into master for users self-hosting, or could be useful for mapit uk if you decide to publish the CCG boundaries (as raised in issue #74).