Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect new MariaDB version numbers #1259

Closed
bgrainger opened this issue Dec 16, 2022 · 1 comment · Fixed by #1311
Closed

Detect new MariaDB version numbers #1259

bgrainger opened this issue Dec 16, 2022 · 1 comment · Fixed by #1311

Comments

@bgrainger
Copy link
Member

bgrainger commented Dec 16, 2022

MDEV-28910 is "removing the 5.5.5- version hack".

Related code: MariaDB/server@1b240b5

Test client version detection when the next version of MariaDB is released (or with a 10.11 dev version).

bgrainger pushed a commit that referenced this issue Apr 20, 2023
fix #1259

Since MariaDB server 11.0.1 (MDEV-28910) won't have "5.5.5-" prefix anymore.
This PR propose to evolve server identification accordingly based on 2 principles:
* version is stripped of "5.5.5-" prefix and identified as MariaDB (The only server that use 'x.y.z-' prefix is percona, but first percona 5.5 server was 5.5.7). MySQL use "x.y.z", alibaba and aurora use x.y.z.a notation)
* server version string contains "MariaDB"

(All mariadb connectors use/will use that exact same behavior for mariadb identification)

Signed-off-by: rusher <diego.dupin@gmail.com>
(cherry picked from commit 275b3e8)
@bgrainger
Copy link
Member Author

Fixed in 2.2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant