Avoid normalize parameter every operation in prepared query #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrainger
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
Do you affirm the Developer Certificate of Origin for this contribution? https://developercertificate.org/
yes, and sorry for missed DCO. |
|
Shipped in 2.2.3; thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using prepared query,
SingleCommandPayloadCreator.WritePreparedStatementcallsparameterCollection?.NormalizedIndexOfand it allocates string(Trim@).However, since the Parameter of a Prepared Statement is always the same, if it is Normalized in advance, it will not be Allocated each time.
This PR adds
List<string?> NormalizedParameterNamestoParsedStatement(ParsedStatementis only used prepared query).Also added MySqlParameterCollection.UnsafeIndexOf, which is an IndexOf that expects the argument to be already normalized.
This improves the performance of Prepared Queries that are executed multiple times.