Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conn.changeUser should eject conn from pool #806

Closed
dougwilson opened this issue May 5, 2014 · 1 comment
Closed

conn.changeUser should eject conn from pool #806

dougwilson opened this issue May 5, 2014 · 1 comment
Labels
Milestone

Comments

@dougwilson
Copy link
Member

When a connection from the pool does .changeUser, it should be ejected from the pool such that the user does not end up in a case where some connections have different contexts.

@dougwilson dougwilson added this to the 2.3 milestone May 5, 2014
@dougwilson dougwilson modified the milestone: 2.3 May 14, 2014
@memelet
Copy link

memelet commented Nov 14, 2014

I have a question about this: I want to use the pool for a multi-tenant app. We have a database per tenant running on a single database (cluster). I was looking forward to using changeUser to select the database as per the tenant making the request. But does this commit mean that if use changeUser I essentially no longer get the benefit of connection pooling? If so, why not just reset the connection when it is returned to the pool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants