Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe Fast Hash support #74

Closed
kchalkias opened this issue Sep 28, 2022 · 1 comment · Fixed by #83
Closed

Unsafe Fast Hash support #74

kchalkias opened this issue Sep 28, 2022 · 1 comment · Fixed by #83
Assignees

Comments

@kchalkias
Copy link
Collaborator

kchalkias commented Sep 28, 2022

This will be required for benchmarking (similarly to empty/dummy signatures). It cannot empty (as collisions can break operations), maybe we can use the fastest non-cryptographically secure hash function for this purpose.

@jonas-lj
Copy link
Contributor

Based on a bit of desktop research, the fastest such non cryptographic hash function seems to be xxHash3. This is based on the benchmarks they provide on their website and this discussion. If no-one objects, I'll give xxHash a go and do some basic benchmarks to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants