Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disabling filtering for supported nodes only in the Android app #447

Closed
soffokl opened this issue Aug 24, 2021 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@soffokl
Copy link
Member

soffokl commented Aug 24, 2021

By default, we are filtering unsupported nodes automatically.
But there should be an option to disable this filtering if a user wants it.
Users should be able to enable/disable in config such auto-detection.

This PR adds const to set NAT compatibility to auto #446
Passing an empty string instead of auto will disable this filter.

@soffokl soffokl added the enhancement New feature or request label Aug 24, 2021
@cvl
Copy link

cvl commented Aug 25, 2021

Is there any specific use case why would anyone want to disable NAT compatibility auto-detection?

@soffokl
Copy link
Member Author

soffokl commented Aug 26, 2021

@cvl
If you are node running you probably want to be able to see your node in the list even if this is not compotible with a current NAT Type.

@cvl
Copy link

cvl commented Aug 26, 2021

Thanks.

Additionally I can see in mysteriumnetwork/mysterium-vpn-desktop#184 that having this auto-detection enabled adds several seconds to load proposals list.

@soffokl
Copy link
Member Author

soffokl commented Aug 26, 2021

This was a part of the discussion, it will not be adding such deley.

@tadaskay
Copy link
Contributor

tadaskay commented Sep 8, 2021

UI from desktop for this setting that you can use as a reference
image

@ArtemHryhorovGeniusee
Copy link
Contributor

Implemented here:
#455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants