Replace 'Users' group lookup with a well-known SID #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadaskay
requested review from
anjmao,
soffokl,
vkuznecovas,
Waldz and
zolia
as code owners
soffokl
approved these changes
Jul 1, 2020
Waldz
approved these changes
Jul 1, 2020
vkuznecovas
approved these changes
Jul 1, 2020
| // https://support.microsoft.com/en-us/help/243330/well-known-security-identifiers-in-windows-operating-systems | ||
| // Looking up by name appears to be unreliable: the name could not be found in localized installations. | ||
| // Using a well-known security identifier here instead. | ||
| usersSID := "S-1-5-32-545" | ||
| sddl := "D:P(A;;GA;;;BA)(A;;GA;;;SY)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2411