Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new discovery for proposals #3379

Merged
merged 5 commits into from
May 13, 2021
Merged

Conversation

tadaskay
Copy link
Member

@tadaskay tadaskay commented May 12, 2021

Fixes: #1810
Fixes: #1594
Fixes: #3366

@tadaskay tadaskay force-pushed the 1810-new-discovery-proposals branch from 2dacf28 to 9a034d6 Compare May 12, 2021 09:42
mdomasevicius and others added 2 commits May 12, 2021 12:45
Signed-off-by: Mantas Domaševičius <mantas@mysterium.network>
@tadaskay tadaskay force-pushed the 1810-new-discovery-proposals branch from 9a034d6 to 3c70014 Compare May 12, 2021 09:45
@tadaskay tadaskay force-pushed the 1810-new-discovery-proposals branch from 3c70014 to c3e3d40 Compare May 13, 2021 06:31
Registration, payout, referrals, etc.
@tadaskay tadaskay force-pushed the 1810-new-discovery-proposals branch from c3e3d40 to 0e34ed7 Compare May 13, 2021 07:54
@codecov-commenter
Copy link

Codecov Report

Merging #3379 (297a0d7) into master (a612f51) will decrease coverage by 0.03%.
The diff coverage is 42.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3379      +/-   ##
==========================================
- Coverage   43.61%   43.57%   -0.04%     
==========================================
  Files         319      311       -8     
  Lines       14048    13546     -502     
==========================================
- Hits         6127     5903     -224     
+ Misses       7199     6937     -262     
+ Partials      722      706      -16     
Impacted Files Coverage Δ
communication/nats/logger.go 33.33% <ø> (ø)
config/flags_location.go 0.00% <0.00%> (ø)
config/flags_payments.go 0.00% <0.00%> (ø)
config/flags_service_noop.go 0.00% <0.00%> (ø)
config/flags_service_openvpn.go 0.00% <0.00%> (ø)
config/flags_service_start.go 0.00% <0.00%> (ø)
config/flags_service_wireguard.go 0.00% <0.00%> (ø)
consumer/session/session.go 50.00% <ø> (ø)
core/discovery/brokerdiscovery/messaging_ping.go 100.00% <ø> (ø)
...re/discovery/brokerdiscovery/messaging_register.go 100.00% <ø> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a612f51...297a0d7. Read the comment docs.

@tadaskay tadaskay merged commit fcce39e into master May 13, 2021
@tadaskay tadaskay deleted the 1810-new-discovery-proposals branch May 13, 2021 08:35
@tadaskay tadaskay mentioned this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants