Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service start #3404

Merged
merged 4 commits into from
May 19, 2021
Merged

Fix service start #3404

merged 4 commits into from
May 19, 2021

Conversation

tadaskay
Copy link
Member

@tadaskay tadaskay commented May 18, 2021

#3379 added required Price for service start request in tequila. This removes the requirement and also allows using pre-saved config values for service pricing (previous web UI behavior) to make it easier to consume.

Copy link
Contributor

@tomasmik tomasmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CI will mention this, but if it doesn't I think swagger also needs an update now.

@codecov-commenter
Copy link

Codecov Report

Merging #3404 (4ee28c1) into master (4f9b967) will increase coverage by 0.04%.
The diff coverage is 43.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3404      +/-   ##
==========================================
+ Coverage   43.62%   43.66%   +0.04%     
==========================================
  Files         320      311       -9     
  Lines       14045    13667     -378     
==========================================
- Hits         6127     5968     -159     
+ Misses       7199     6979     -220     
- Partials      719      720       +1     
Impacted Files Coverage Δ
ci/release/debian.go 0.00% <ø> (ø)
communication/nats/connection_wrap.go 69.23% <0.00%> (-10.19%) ⬇️
communication/nats/logger.go 33.33% <ø> (ø)
config/flags_chains.go 61.40% <0.00%> (ø)
config/flags_location.go 0.00% <0.00%> (ø)
config/flags_network.go 0.00% <0.00%> (ø)
config/flags_payments.go 0.00% <0.00%> (ø)
config/flags_service_noop.go 0.00% <0.00%> (ø)
config/flags_service_openvpn.go 0.00% <0.00%> (ø)
config/flags_service_start.go 0.00% <0.00%> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6615687...4ee28c1. Read the comment docs.

@tadaskay tadaskay merged commit f952d28 into master May 19, 2021
@tadaskay tadaskay deleted the fix-service-start branch May 19, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants