Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang version #4349

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Bump golang version #4349

merged 5 commits into from
Nov 26, 2021

Conversation

Snawoot
Copy link
Contributor

@Snawoot Snawoot commented Nov 25, 2021

Bump golang version and disable iOS build.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #4349 (71f0ced) into master (0ba8126) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 71f0ced differs from pull request most recent head 4de3feb. Consider uploading reports for the commit 4de3feb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4349      +/-   ##
==========================================
+ Coverage   41.05%   41.06%   +0.01%     
==========================================
  Files         334      334              
  Lines       17874    17869       -5     
==========================================
  Hits         7338     7338              
+ Misses       9841     9837       -4     
+ Partials      695      694       -1     
Impacted Files Coverage Δ
requests/dialer_swarm.go 73.68% <0.00%> (-3.76%) ⬇️
tequilapi/client/client.go 3.65% <0.00%> (+0.01%) ⬆️
session/pingpong/hermes_promise_settler.go 36.28% <0.00%> (+0.19%) ⬆️
nat/traversal/pinger.go 79.84% <0.00%> (+1.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba8126...4de3feb. Read the comment docs.

Copy link
Member

@soffokl soffokl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Snawoot Snawoot marked this pull request as ready for review November 26, 2021 11:09
@Snawoot Snawoot merged commit f662e79 into master Nov 26, 2021
@Snawoot Snawoot deleted the bump_golang branch November 26, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants