Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final removal of "openvpn" wording #496

Merged
merged 6 commits into from
Nov 12, 2018
Merged

Final removal of "openvpn" wording #496

merged 6 commits into from
Nov 12, 2018

Conversation

Waldz
Copy link
Member

@Waldz Waldz commented Oct 24, 2018 •
edited by vkuznecovas
Loading

Updates #476

Updates #530

Leftovers:

  • TODO Decouple stats.Sender from 'openvpn' states
  • TODO Move stats.Sender from 'openvpn' package
  • TODO Register Openvpn flags as transport "openvpn" arguments Factory service dynamically #499
  • TODO Bootstrap services in desktop entrypoint only
  • TODO Bootstrap openvpn together with transport
  • TODO Use transport mock in tests instead of real openvpn
  • Move mysteriumnetwork/go-openvpn/openvpn/core to node repo

@Waldz Waldz requested a review from tadovas as a code owner October 24, 2018 14:39
@Waldz Waldz changed the base branch from master to enhancement/stateless-connection-factory October 24, 2018 14:45
This was referenced Oct 24, 2018
Merged
Closed
@Waldz
Copy link
Member Author

Waldz commented Oct 25, 2018

Anyone from @mysteriumnetwork/core, who want to finish this initiative?

@tadovas
Copy link
Contributor

tadovas commented Oct 26, 2018

Suggestion to merge at least done parts. If we leave this PR open for too long it will stale and be unmergeable

@Waldz Waldz changed the base branch from enhancement/stateless-connection-factory to master October 27, 2018 07:42
tadovas
tadovas previously requested changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@tadovas tadovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Waldz this one is on you - you need to decide how to handle this PR. Either mark it on progress or commit some parts and close it.

@vkuznecovas
Copy link
Contributor

I'll take this over. Created #530 so we can spread it over separate PR's

@Waldz Waldz requested a review from zolia as a code owner November 9, 2018 14:09
@vkuznecovas vkuznecovas merged commit 3f18b20 into master Nov 12, 2018
@vkuznecovas vkuznecovas deleted the feature/remove-openvpn-wording branch November 12, 2018 11:03
@vkuznecovas vkuznecovas mentioned this pull request Nov 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadovas tadovas tadovas approved these changes

@soffokl soffokl soffokl approved these changes

@zolia zolia zolia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Waldz @tadovas @vkuznecovas @soffokl @zolia