Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location cache gets never updated sometimes #6048

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

soffokl
Copy link
Member

@soffokl soffokl commented May 16, 2024

The needsRefresh method in the location cache has been refactored to correctly check if the cache needs to be refreshed. The previous implementation used the After method, but it has been changed to use the Before method to ensure accurate comparison with the expiry time. This change improves the reliability of the cache refresh mechanism.

The needsRefresh method in the location cache has been refactored to correctly check if the cache needs to be refreshed. The previous implementation used the After method, but it has been changed to use the Before method to ensure accurate comparison with the expiry time. This change improves the reliability of the cache refresh mechanism.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.90%. Comparing base (4a517cd) to head (bc3b56e).
Report is 71 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6048   +/-   ##
=======================================
  Coverage   37.90%   37.90%           
=======================================
  Files         371      371           
  Lines       20665    20715   +50     
=======================================
+ Hits         7833     7852   +19     
- Misses      12054    12076   +22     
- Partials      778      787    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soffokl soffokl merged commit 365054f into master May 16, 2024
19 checks passed
@soffokl soffokl deleted the fix-location-cache branch May 16, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants