Filter out unsupported proposals #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As part of this feature I am planning to refactor our discovery communication code (get rid of packages like "server" and to extract consumer and provider related code to separate packages) |
vkuznecovas
previously approved these changes
Dec 10, 2018
zolia
reviewed
Dec 10, 2018
service_discovery/dto/contact.go
Outdated
| return UnsupportedContactType{} | ||
| } | ||
| definition, er := fn(rawMessage) | ||
| if er != nil { |
zolia
reviewed
Dec 10, 2018
| "github.com/mysteriumnetwork/node/money" | ||
| ) | ||
|
|
||
| // PaymentMethod is a marker interface for all types of payment methods |
zolia
reviewed
Dec 10, 2018
zolia
reviewed
Dec 10, 2018
zolia
reviewed
Dec 10, 2018
tadovas
force-pushed
the
feature/handle-unsupported-proposals
branch
from
99af05e
to
94dead9
Compare
soffokl
reviewed
Dec 11, 2018
tadovas
force-pushed
the
feature/handle-unsupported-proposals
branch
from
8bca9ad
to
9cb77dc
Compare
|
@zolia @vkuznecovas @soffokl ready again |
soffokl
approved these changes
Dec 11, 2018
zolia
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea how to handle proposals of uknown service,payment or contact types.
Proposal is considered unsupported if one of the following is true:
Such proposals will be filtered out and not returned by tequilapi