Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security warning #41

Closed
quilicicf opened this issue Jun 13, 2018 · 4 comments
Closed

Fix security warning #41

quilicicf opened this issue Jun 13, 2018 · 4 comments

Comments

@quilicicf
Copy link
Contributor

quilicicf commented Jun 13, 2018

Hi,

When installing cpx as a dependency of a project, npm gave me a warning about a vulnerability.
The problem comes from dependency chokidar, I've created an issue there.

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ deep-extend                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ cpx [dev]                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ cpx > chokidar > fsevents > node-pre-gyp > rc > deep-extend  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/612                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

I also noticed that the badge on the README points to another vulnerability, on debug this time (cf David report).

Thanks for developing cpx.
I can commit a fix if that helps.

@quilicicf
Copy link
Contributor Author

I opened a PR to try and fix all non-low vulnerabilities: #43

@mysticatea
Copy link
Owner

I'm sorry for my overlook. Thank you for this report and that PR.

I will take a look the PR within this week.

@quilicicf
Copy link
Contributor Author

No harm done, thanks

@mysticatea
Copy link
Owner

#43 was merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants