Fix: README etc. are only assumed published if in pkg root (fixes #73) (

#74)
mysticatea · Mar 28, 2017 · b2c6877 · b2c6877
1 parent fb3f030
commit b2c6877
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/lib/util/get-npmignore.js b/lib/util/get-npmignore.js
@@ -77,7 +77,7 @@ function filterNeverIgnoredFiles(p) {
     return (filePath) => (
         path.join(basedir, filePath) !== mainFilePath &&
         filePath !== "package.json" &&
-        !NEVER_IGNORED.test(path.basename(filePath))
+        !NEVER_IGNORED.test(path.relative(basedir, filePath))
     )
 }
 

diff --git a/tests/fixtures/no-unpublished/3/src/readme.js b/tests/fixtures/no-unpublished/3/src/readme.js
diff --git a/tests/lib/rules/no-unpublished-import.js b/tests/lib/rules/no-unpublished-import.js
@@ -121,6 +121,13 @@ ruleTester.run("no-unpublished-import", rule, {
             code: "import electron from 'electron';",
             options: [{allowModules: ["electron"]}],
         },
+
+        // Auto-published files only apply to root package directory
+        {
+            filename: fixture("3/src/readme.js"),
+            code: "import bbb from 'bbb';",
+            env: {node: true},
+        },
     ],
     invalid: [
         {

diff --git a/tests/lib/rules/no-unpublished-require.js b/tests/lib/rules/no-unpublished-require.js
@@ -235,6 +235,13 @@ ruleTester.run("no-unpublished-require", rule, {
             options: [{allowModules: ["electron"]}],
             env: {node: true},
         },
+
+        // Auto-published files only apply to root package directory
+        {
+            filename: fixture("3/src/readme.js"),
+            code: "require('bbb');",
+            env: {node: true},
+        },
     ],
     invalid: [
         {