-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: add plugin:node/recommended
config
#39
New: add plugin:node/recommended
config
#39
Conversation
5b49c52
to
4827e1c
Compare
Thank you for the PR and issue! It's good that we have the recommended setting. But I have 3 concerns on this implement.
|
ab32f10
to
fd311c3
Compare
Thank u so much for your reviewing. I could not understand well eslint-plugin-node's design of rule I took your comments into consideration.
And, to realize above things I edited some codes.
If u have some better opinions for my commits, pls let me know. Thanks. |
Ah, I'm sorry for my explanation is not enough. |
fd311c3
to
662f107
Compare
662f107
to
c21eed5
Compare
I'm sorry I couldn't understand your intension. I reverted and created If you have some advices, please let me know. Thanks! |
Thank you so much! |
Thanks a lot! |
This pull request is one of PoC for #38 .
If this is merged, we can configure .eslintrc using plugin:node/recommended.
like this
This configure equals to