Fix bad test

This fixes a test that was always returning true despite the fact that one of the cases fails. This fixes the test, but one case still fails.
mythmon · Mar 5, 2013 · de8b552 · de8b552
1 parent f846be3
commit de8b552
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/fjord/base/tests/test_browser.py b/fjord/base/tests/test_browser.py
@@ -20,9 +20,10 @@ def check_ua(self, case):
                           'platform', 'platform_version',
                           'mobile'])
 
-        assert (parsed == expected,
-                'UA Detection failed. UA="{0}", parsed="{1}" expected="{2}"'
-                .format(case['user_agent'], parsed, expected))
+        msg = ('UA Detection failed. UA="{0}", parsed="{1}" '
+               'expected="{2}"'.format(
+                case['user_agent'], parsed, expected))
+        assert parsed == expected, msg
 
     def test_parse_ua(self):
         """Test that a suite of should-work user agents work."""