Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mythweb still uses the setting 'MasterServerIP' albeit obsolete #89

Open
rcrdnalor opened this issue Jul 2, 2023 · 0 comments
Open

Comments

@rcrdnalor
Copy link
Contributor

rcrdnalor commented Jul 2, 2023

On a fresh install, I get an empty page of the page mythweb/status, like http://localhost/mythweb/status/
Visiting the source of that page, I find this statement when retrieving http://localhost/mythweb/status

<div id="content_wrapper">
<!-- Obtained from:  http://:6544 -->

</div>

This is caused by mythweb using the obsolete setting of MasterServerIP in
https://github.com/MythTV/mythweb/blob/92f0f9bc6d15f6d6534e5d5e40bdddbb6f431254/modules/status/handler.php#L14C81-L14C81

    $masterhost = preg_replace('@(.*?:.*)@', "[$1]", setting('MasterServerIP'));

Within MythTV, the function GetMasterServerIP wthin MythTV now retuns the evaluation of

https://github.com/MythTV/mythtv/blob/c909c36018eec4dc570b9a5d67592850c76c40ac/mythtv/libs/libmythbase/mythcorecontext.cpp#L962
which shows that MasterServerIP is not a static setting setting anymore.

I found multiple usages of ´MasterServerIP` within mythweb, please eveluate every occurrence.

@rcrdnalor rcrdnalor changed the title Mythweb still usses the setting 'MasterServerIP' albeit obsolete Mythweb still uses the setting 'MasterServerIP' albeit obsolete Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant