New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features and unit tests enhancements #289
Conversation
… implementation) (#38)
Conflicts: info/release-notes/21.next.0-readme.txt
The action name is a little bit long and contains words which are not needed in the short name, I would name this action e.g. Export Map As Image. When a longer description is needed then it could be displayed as tooltip text An improvement could be to also export it to the clipboard. I've not yet reviewed the code, in which format is the image saved? You should keep in mind that images can be displayed in the map, so jpg or png 24bit should be used. |
Ok, I will shorten the text
The export dialog gives you the choice between JPG, BMP and PNG. |
@wolfgang-ch I have updated my PR with your suggestion and I have added the action to export the map view in the clipboard |
response was too long (in french for example). Fixed the browser's response for languages with accents
Done. I also updated the PR screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something strange happened, before I merged this PR here with github, I resetted FJBDev branch in my repo to my main branch because I saw this commit as my last commit in this PR. Then I merged and squashed it here with github, but now I don't see any of your modifications in my FJBDev branch.
So I reseted FJBDev in my repo to your last merge 53b9fe7
Can you create a new PR ?
There are still some ??? how this github merge works
@wolfgang-ch I have created a new PR with the same exact modifications here |
Unit tests 100% successful
See, I added mnemonics 😃