Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features and unit tests enhancements #289

Merged
merged 90 commits into from Jan 20, 2021
Merged

Conversation

FJBDev
Copy link
Collaborator

@FJBDev FJBDev commented Jan 13, 2021

  • Adding the possibility to configure a User Agent for each custom map provider

image

  • Added the possibility to export the current map view to an image file (jpg, png or bmp) (Per feature request)

image

image

  • Unit tests: Fixed the persistence manager issue and now the FitLog and FitLogEx tests are operational and successful

Unit tests 100% successful

image

See, I added mnemonics 😃

Conflicts:
	info/release-notes/21.next.0-readme.txt
@FJBDev FJBDev changed the title New features and unit tests fix New features and unit tests enhancements Jan 16, 2021
@wolfgang-ch
Copy link
Collaborator

image

The action name is a little bit long and contains words which are not needed in the short name, I would name this action e.g. Export Map As Image. When a longer description is needed then it could be displayed as tooltip text

mt-action-tooltiptext-2

An improvement could be to also export it to the clipboard.

I've not yet reviewed the code, in which format is the image saved? You should keep in mind that images can be displayed in the map, so jpg or png 24bit should be used.

@FJBDev
Copy link
Collaborator Author

FJBDev commented Jan 16, 2021

The action name is a little bit long and contains words which are not needed in the short name, I would name this action e.g. Export Map As Image. When a longer description is needed then it could be displayed as tooltip text

Ok, I will shorten the text

I've not yet reviewed the code, in which format is the image saved? You should keep in mind that images can be displayed in the map, so jpg or png 24bit should be used.

The export dialog gives you the choice between JPG, BMP and PNG.

image

@FJBDev
Copy link
Collaborator Author

FJBDev commented Jan 17, 2021

@wolfgang-ch I have updated my PR with your suggestion and I have added the action to export the map view in the clipboard

@wolfgang-ch
Copy link
Collaborator

* Added the possibility to export the current map view to an image file (jpg, png or bmp) (Per [feature request](https://github.com/wolfgang-ch/mytourbook/issues/174))

image

Can you put the export actions into a submenu action (similar like Dim Map),

E&xport Map
-- As &Image...
-- To &Clipboard

@FJBDev
Copy link
Collaborator Author

FJBDev commented Jan 18, 2021

Can you put the export actions into a submenu action (similar like Dim Map),

E&xport Map
-- As &Image...
-- To &Clipboard

Done. I also updated the PR screenshot.

Copy link
Collaborator

@wolfgang-ch wolfgang-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FJBDev

Something strange happened, before I merged this PR here with github, I resetted FJBDev branch in my repo to my main branch because I saw this commit as my last commit in this PR. Then I merged and squashed it here with github, but now I don't see any of your modifications in my FJBDev branch.

So I reseted FJBDev in my repo to your last merge 53b9fe7

Can you create a new PR ?

There are still some ??? how this github merge works

@FJBDev
Copy link
Collaborator Author

FJBDev commented Jan 20, 2021

@wolfgang-ch
Weird.... Github can be a pain sometimes. I hope we can resolve those issues soon.

I have created a new PR with the same exact modifications here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants