Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to make the coverage 100% #54

Closed
mzy2240 opened this issue May 29, 2020 · 3 comments
Closed

Add more tests to make the coverage 100% #54

mzy2240 opened this issue May 29, 2020 · 3 comments
Assignees

Comments

@mzy2240
Copy link
Owner

mzy2240 commented May 29, 2020

@blthayer Right now the coverage is about 96%. I checked the coverage reports and noticed the uncovered lines come from the newly-added exception handling for the old version of PW. Since you are more familiar with the mock module, can you add some tests for these exceptions?

@blthayer
Copy link
Collaborator

@mzy2240 - I can do that, hopefully today, but I may not have time. I think it would be okay to release with 96% coverage and update the tests later if that's okay with you and I run out of time today.

@mzy2240
Copy link
Owner Author

mzy2240 commented May 29, 2020

Okay no problem. Besides the coverage, it passed all the tests. I will release the new version later.

blthayer pushed a commit that referenced this issue May 29, 2020
…mulator still achieves 100% coverage. This closes out #54
@blthayer
Copy link
Collaborator

@mzy2240 - I was able to get this done, but won't have much more time for ESA in the next week.

Please note that one of the doctests is still failing because of the AreaNum issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants