Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to inbuilt extractor using youtube dl exec #27

Closed
n-ce opened this issue Mar 1, 2022 · 1 comment
Closed

Migrate to inbuilt extractor using youtube dl exec #27

n-ce opened this issue Mar 1, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Javascript

Comments

@n-ce
Copy link
Owner

n-ce commented Mar 1, 2022

Current extractor is an outsourced URL.
Reason for change : takes longer time processing, not all links work.
Create a new extractor using npm module YouTube DL exec which will provide the file to be played to the audio source.

Line on Focus :

audio.src = `https://projectlounge.pw/ytdl/download?url=https://youtu.be/${x}&format=${c}`;

Where x is the video id & c is the codec value such as 249, 251.

PR to the "node" branch.

@n-ce n-ce added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Javascript labels Mar 1, 2022
@n-ce n-ce mentioned this issue Mar 2, 2022
@n-ce n-ce linked a pull request Mar 2, 2022 that will close this issue
@n-ce
Copy link
Owner Author

n-ce commented Mar 16, 2022

Postpone extractor requirement to future releases

@n-ce n-ce closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Javascript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant