Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Add support for vote tx in nyzostrings #19

Closed
AngainorDev opened this issue May 14, 2020 · 3 comments
Closed

Add support for vote tx in nyzostrings #19

AngainorDev opened this issue May 14, 2020 · 3 comments

Comments

@AngainorDev
Copy link

Nyzo Strings currently define:

  • Micropay("pay_")
  • PrefilledData("pre_")
  • PrivateSeed("key_")
  • PublicIdentifier("id__")
  • Signature("sig_")
  • Transaction("tx__")

tx__ is quite useful to locally sign a transaction then send it for inclusion.
The client api has a "forward transaction" endpoint for that.

However, type 4 txs (vote) do not follow the same data structure as usual transactions and can't be encoded the same way.

Thus, we'd like to suggest a new nyzostring type - tx4_ for instance - that would represent a type 4 signed vote tx.
"Forward transaction" endpoint could then handle both tx__ and tx4_.

@n-y-z-o
Copy link
Owner

n-y-z-o commented May 14, 2020

This has been corrected on https://client.nyzo.co, and the fix will be released as version 584.

The problem was actually in the run() method of TransactionForwardCommand. In building the result table, a NyzoStringPublicIdentifier was built with the receiver identifier of the transaction. This field is null for a cycle-signature transaction, and a null-pointer exception was thrown. This caused the "Unexpected issue forwarding transaction..." error.

Version 584 is already live on client.nyzo.co, so it is now able to forward cycle-signature transactions.

@n-y-z-o
Copy link
Owner

n-y-z-o commented May 15, 2020

This issue has been corrected with the release of version 584. While a new Nyzo string type was not added, the current Nyzo transaction string supports all transaction types, and the issue of forwarding type-4 (cycle-signature) transactions was corrected.

@n-y-z-o n-y-z-o closed this as completed May 15, 2020
@AngainorDev
Copy link
Author

Awesome, thanks!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants