Skip to content

Commit

Permalink
chore(ci): run cargo build for android platforms (#1843)
Browse files Browse the repository at this point in the history
## Description

Due to a bug in redb we are currently not running tets on android.
This is a bit problematic as we break android builds this way.

This makes sure we can at least build, so the linker will also run.

## Notes & open questions

The next step would be to run the tests for android which do not
depend on redb.
 
Running `cargo check` in a separate step does not provide any benefit,
it is an extra compiler step which does take time and does not result
in catching errors which otherwise aren't caught.  Maybe we should also
remove this step from the non-cross checks, but that belongs better in
a different PR probably.

## Change checklist

- [x] Self-review.
- ~~Documentation updates if relevant.~~
- ~~Tests if relevant.~~
  • Loading branch information
flub committed Nov 25, 2023
1 parent d1fcfca commit 227f0e8
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,12 @@ jobs:
# See https://github.com/cross-rs/cross/issues/1222
run: cargo install cross --git https://github.com/cross-rs/cross

- name: check
run: cross check --all --target ${{ matrix.target }}
- name: build
# cross tests are currently broken vor armv7 and aarch64
# see https://github.com/cross-rs/cross/issues/1311. So on
# those platforms we only build but do not run tests.
if: matrix.target != 'i686-unknown-linux-gnu'
run: cross build --all --target ${{ matrix.target }}
env:
RUST_LOG: ${{ runner.debug && 'DEBUG' || 'INFO'}}

Expand Down

0 comments on commit 227f0e8

Please sign in to comment.