Skip to content

Commit

Permalink
fix(iroh-cli): Fix printing of doctor connect/accept output (#2166)
Browse files Browse the repository at this point in the history
## Description

Apparently now metrics work and are attempted to be printed.
Unfortunately they also print a tracing error message to stderr, the
stderr which is also being used by the progress bar.  The result is
that the progress bar ends up with an extra newline and the first line
of it is not being repainted but flows up, resulting in lots of
garbage in the terminal history.

By removing the log message the output is perserved much better.

## Notes & open questions

It could be argued that this is not a good fix, if the loglevel is
changed to info or debug the same problems would occur.  However we
already have the ability to log to a random filedescriptor and will
soon be able to log to files.  So maybe that's just fine for now.

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- ~~[ ] Tests if relevant.~~
  • Loading branch information
flub committed Apr 10, 2024
1 parent ceaf168 commit 5d4ac52
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion iroh-cli/src/commands/doctor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ impl Gui {
fn update_counters(target: &ProgressBar) {
if let Some(core) = Core::get() {
let metrics = core.get_collector::<MagicsockMetrics>().unwrap();
tracing::error!("metrics enabled");
let send_ipv4 = HumanBytes(metrics.send_ipv4.get());
let send_ipv6 = HumanBytes(metrics.send_ipv6.get());
let send_relay = HumanBytes(metrics.send_relay.get());
Expand Down

0 comments on commit 5d4ac52

Please sign in to comment.