fix(iroh-cli): Fix printing of doctor connect/accept output #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently now metrics work and are attempted to be printed. Unfortunately they also print a tracing error message to stderr, the stderr which is also being used by the progress bar. The result is that the progress bar ends up with an extra newline and the first line of it is not being repainted but flows up, resulting in lots of garbage in the terminal history. By removing the log message the output is perserved much better. It could be argued that this is not a good fix, if the loglevel is changed to info or debug the same problems would occur. However we already have the ability to log to a random filedescriptor and will soon be able to log to files. So maybe that's just fine for now.
rklaehn
approved these changes
Apr 10, 2024
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 11, 2024
…ter#2166) ## Description Apparently now metrics work and are attempted to be printed. Unfortunately they also print a tracing error message to stderr, the stderr which is also being used by the progress bar. The result is that the progress bar ends up with an extra newline and the first line of it is not being repainted but flows up, resulting in lots of garbage in the terminal history. By removing the log message the output is perserved much better. ## Notes & open questions It could be argued that this is not a good fix, if the loglevel is changed to info or debug the same problems would occur. However we already have the ability to log to a random filedescriptor and will soon be able to log to files. So maybe that's just fine for now. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates if relevant.~~ - ~~[ ] Tests if relevant.~~
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 11, 2024
…ter#2166) ## Description Apparently now metrics work and are attempted to be printed. Unfortunately they also print a tracing error message to stderr, the stderr which is also being used by the progress bar. The result is that the progress bar ends up with an extra newline and the first line of it is not being repainted but flows up, resulting in lots of garbage in the terminal history. By removing the log message the output is perserved much better. ## Notes & open questions It could be argued that this is not a good fix, if the loglevel is changed to info or debug the same problems would occur. However we already have the ability to log to a random filedescriptor and will soon be able to log to files. So maybe that's just fine for now. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates if relevant.~~ - ~~[ ] Tests if relevant.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently now metrics work and are attempted to be printed.
Unfortunately they also print a tracing error message to stderr, the
stderr which is also being used by the progress bar. The result is
that the progress bar ends up with an extra newline and the first line
of it is not being repainted but flows up, resulting in lots of
garbage in the terminal history.
By removing the log message the output is perserved much better.
Notes & open questions
It could be argued that this is not a good fix, if the loglevel is
changed to info or debug the same problems would occur. However we
already have the ability to log to a random filedescriptor and will
soon be able to log to files. So maybe that's just fine for now.
Change checklist
[ ] Documentation updates if relevant.[ ] Tests if relevant.