Skip to content

Commit

Permalink
tests: Remove flaky label from windows-DNS affected tests (#2223)
Browse files Browse the repository at this point in the history
## Description

They have been stable on CI for a while now.  Maybe the DNS config
tweak we did in #2075 made a difference.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

Closes #2086 

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~
  • Loading branch information
flub committed Apr 23, 2024
1 parent 1432d61 commit 93bcaa5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions iroh-net/src/dns.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ pub(crate) mod tests {
use super::*;

#[tokio::test]
#[cfg_attr(target_os = "windows", ignore = "flaky")]
async fn test_dns_lookup_basic() {
let _logging = iroh_test::logging::setup();
let resolver = default_resolver();
Expand All @@ -166,7 +165,6 @@ pub(crate) mod tests {
}

#[tokio::test]
#[cfg_attr(target_os = "windows", ignore = "flaky")]
async fn test_dns_lookup_ipv4_ipv6() {
let _logging = iroh_test::logging::setup();
let resolver = default_resolver();
Expand Down
1 change: 0 additions & 1 deletion iroh-net/src/netcheck/reportgen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1315,7 +1315,6 @@ mod tests {
// /etc/sysctl.conf or /etc/sysctl.d/* to persist this accross reboots.
//
// TODO: Not sure what about IPv6 pings using sysctl.
#[cfg_attr(target_os = "windows", ignore = "flaky")]
#[tokio::test]
async fn test_icmpk_probe_eu_relayer() {
let _logging_guard = iroh_test::logging::setup();
Expand Down

0 comments on commit 93bcaa5

Please sign in to comment.