Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS still flaky on windows #2086

Closed
flub opened this issue Mar 15, 2024 · 3 comments · Fixed by #2223
Closed

DNS still flaky on windows #2086

flub opened this issue Mar 15, 2024 · 3 comments · Fixed by #2223
Assignees
@ramfox
Labels
c-iroh-net flaky-test

Comments

@flub
Copy link
Contributor

flub commented Mar 15, 2024

It seems the windows CI is still giving us timeouts on DNS resolution. This is weird.
@flub flub mentioned this issue Mar 15, 2024
Merged
3 tasks
@ramfox ramfox self-assigned this Mar 25, 2024
@ramfox
Copy link
Contributor

ramfox commented Apr 18, 2024

After some attempts by both @Arqu and I a few weeks ago, we were both unable to trigger the DNS test failure. I also checked: since this issue was created (which is, I'm assuming the same time that this test was flakey on CI) it hasn't failed on a single "Flakey: CI" run.

So, when do we decide that this isn't really a flakey test, and that your previous work on DNS actually fixed the issue?

@flub
Copy link
Contributor Author

flub commented Apr 19, 2024

if there isn't a single flaky instance of this let's move it back to not flaky. if it turns out flaky again it'll be moved back to the sin bin swiftly enough

@flub flub mentioned this issue Apr 23, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
@flub
tests: Remove flaky label from windows-DNS affected tests (#2223)
93bcaa5 
## Description

They have been stable on CI for a while now.  Maybe the DNS config
tweak we did in #2075 made a difference.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

Closes #2086 

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~
@flub flub reopened this May 6, 2024
@flub flub mentioned this issue May 6, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue May 6, 2024
@flub
tests: Disable flaky tests on windowns again (#2267)
6cc12d8 
## Description

This reverts commit 93bcaa5.

Re-opens #2086

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.
This was referenced May 7, 2024
Closed
Closed
@flub flub mentioned this issue May 14, 2024
Closed
4 tasks
@flub
Copy link
Contributor Author

flub commented Jun 18, 2024

Let's try to close this again. The staggered DNS approach seems successful.

@flub flub closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramfox ramfox

Labels
c-iroh-net flaky-test
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Remove flaky label from windows-DNS affected tests n0-computer/iroh
2 participants
@flub @ramfox