ref(ci): Do not run cargo check separately and test all features #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cargo check runs do not help with any speedup, they cost >20s, do not test anything that's not already covered by other tests. So remove them. Updates the cargo test invocations to: - Use --workspace instead of deprecated --all. We don't have a workspace crate yet though so could just remove it for now, but this is a bit more future-proof I guess. - Use --all-features since we have no features that are incompatible with each other. Let's keep it that way! - Select the --lib --bins and --tests targets, --all-targets would include the benches which we probably don't want to run as part of the main test run, but we don't have any yet so that is also just future-proofing.
flub
commented
Jun 6, 2023
|
|
||
| - name: check bench | ||
| if: matrix.rust == 'nightly' | ||
| run: cargo check --target ${{ matrix.target }} --benches |
There was a problem hiding this comment.
We don't have any benches, so i removed this.
|
@Arqu any objections? |
| - name: tests | ||
| run: cargo test --all | ||
| run: cargo test --workspace --all-features --lib --bins --tests |
There was a problem hiding this comment.
I think this is removing the docs tests. There is only one though..
There was a problem hiding this comment.
good catch, thanks!
#1095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cargo check runs do not help with any speedup, they cost >20s, do
not test anything that's not already covered by other tests. So
remove them.
Updates the cargo test invocations to:
Use --workspace instead of deprecated --all. We don't have a
workspace crate yet though so could just remove it for now, but this
is a bit more future-proof I guess.
Use --all-features since we have no features that are incompatible
with each other. Let's keep it that way!
Select the --lib --bins and --tests targets, --all-targets would
include the benches which we probably don't want to run as part of the
main test run, but we don't have any yet so that is also just
future-proofing.