Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ci): Do not run cargo check separately and test all features #1079

Merged
merged 1 commit into from
Jun 9, 2023
Merged

ref(ci): Do not run cargo check separately and test all features #1079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,8 @@ jobs:
with:
toolchain: ${{ matrix.rust }}

- name: check
run: cargo check --all --bins --tests

- name: tests
run: cargo test --all
run: cargo test --workspace --all-features --lib --bins --tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is removing the docs tests. There is only one though..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!
#1095


build_and_test_windows:
name: Build and test (Windows)
Expand Down Expand Up @@ -87,15 +84,8 @@ jobs:

- uses: msys2/setup-msys2@v2

- name: check
run: cargo check --all --bins --tests --target ${{ matrix.target }}

- name: check bench
if: matrix.rust == 'nightly'
run: cargo check --target ${{ matrix.target }} --benches
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any benches, so i removed this.


- name: tests
run: cargo test --all --target ${{ matrix.target }}
run: cargo test --workspace --all-features --lib --bins --tests --target ${{ matrix.target }}

build_release:
name: Build release binaries
Expand Down Expand Up @@ -247,6 +237,8 @@ jobs:
with:
components: clippy

# TODO: We have a bunch of platform-dependent code so should
# probably run this job on the full platofrm matrix
- name: clippy check
run: cargo clippy --message-format=json --all-features --all-targets

Expand Down
Loading