fix(iroh_net): less agressive best_addr clearing on pong timeout #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h is not alive in the timeout period
|
does this fix #2169? |
|
awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clears the best address only if within the time the pong should have been received, nothing else was seen so that the address is considered not alive in that period. This should result in less aggressive best_addr clearing.
Specific changes include:
BestAddr::clear_if_addr_oldersince it is no longer needed.BestAddr::clear*return since it was never read anyway.PING_TIMEOUT_DURATIONbefore clearing the best address on timeoutBreaking Changes
n/a
Notes & open questions
n/a
Change checklist
Tests if relevant.All breaking changes documented.