-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76 #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
refactor-api
branch
from
May 6, 2024 14:23
2ce0277
to
b21f9cc
Compare
Needs rebase |
Frando
force-pushed
the
refactor-api-simplify-client-generics
branch
from
May 21, 2024 08:22
e39a486
to
68b341b
Compare
Rebased this. Needs a quic-rpc release first though. |
release is done |
Rebased again and bumped quic-rpc. Should be good to go now. Edit: quic-rpc has MSRV 1.76, so bumped ours from 1.75 to 1.76 as well. |
Frando
changed the title
refactor: quic-rpc simpler generics
refactor: update quic-rpc, simlify generics, bump MSRV to 1.76
May 22, 2024
dignifiedquire
approved these changes
May 23, 2024
working on deps updates here: n0-computer/quic-rpc#80 |
dignifiedquire
changed the title
refactor: update quic-rpc, simlify generics, bump MSRV to 1.76
fea!: new quic-rpc, simlified generics, bump MSRV to 1.76
May 24, 2024
dignifiedquire
changed the title
fea!: new quic-rpc, simlified generics, bump MSRV to 1.76
feat!: new quic-rpc, simlified generics, bump MSRV to 1.76
May 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapts iroh for n0-computer/quic-rpc#76
Wit this change, a quic client is
pub type QuicIroh = Iroh<QuinnConnection<RpcService>>
instead of
pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest, ProviderResponse>>
Breaking Changes
ProviderRequest, ProviderResponse
as generics, they now takeRpcService
Notes & open questions
Change checklist