Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cclasses don't handle multiple rerolls #25

Closed
n0q opened this issue May 20, 2021 · 1 comment · Fixed by #120
Closed

cclasses don't handle multiple rerolls #25

n0q opened this issue May 20, 2021 · 1 comment · Fixed by #120
Labels
good first issue Good for newcomers refactor This should be redone.

Comments

@n0q
Copy link
Owner

n0q commented May 20, 2021

Presently, a character class can gracefully handle being told it's a "reroll hitdie", but only if the prior one was a new hitdie. I don't think any character classes throw consecutive rerolls at the player, but we should handle this anyway, for homebrew or new character classes.
@n0q n0q added unconfirmed-bug good first issue Good for newcomers refactor This should be redone. and removed unconfirmed-bug labels May 20, 2021
@n0q
Copy link
Owner Author

n0q commented Jun 21, 2021 •
edited
Loading

Made obsolete by #114

@n0q n0q closed this as completed Jun 21, 2021
@n0q n0q reopened this Jun 22, 2021
@n0q n0q linked a pull request Jun 22, 2021 that will close this issue
character class refactor #120
Merged
@n0q n0q closed this as completed in #120 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor This should be redone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

character class refactor n0q/hackmaster5e-fvtt
1 participant
@n0q