Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN files #47

Closed
tomByrer opened this issue Mar 28, 2014 · 4 comments
Closed

CDN files #47

tomByrer opened this issue Mar 28, 2014 · 4 comments

Comments

@tomByrer
Copy link

I was going to throw this up on a free CDN, jsDelivr, but saw the CSS is not minified, & seems that it needs configuring.

IMHO resets should be separate, & with jsDelivr you can d/l a concocted file. (eg //cdn.jsdelivr.net/g/normalize@3.0,skeljs@0.5.0(skel-noscript.min.css)). If there is configuring needed, then perhaps there should be separate files that you can load as-needed?

@ajlkn
Copy link
Owner

ajlkn commented Mar 29, 2014

Actually the whole thing needs a bit of configuring since the container/gutter size values are used throughout the stylesheet (not to mention your choice of whether to normalize, reset, or neither).

@tomByrer
Copy link
Author

choice of whether to normalize, reset, or neither

Sorry, but I & most devs don't agree with including resets that you MIGHT use as part of the main CSS file. If you want people to edit text, IMHO it should not be inside the files you provide, but inside their own HTML, CSS, or JS. Same idea with your JS configuring; you don't want them to hack your main JS files. So many better & more flexible choices:

  • add your own choice of CSS reset as part of HTML before CSS: eg <link rel="stylesheet" href="http://cdn.jsdelivr.net/normalize/3.0/normailze.css"> & instruct to add their own site.css after your skel.css (what I do for Bootstrap.css)
  • dev uses their own build process (eg Grunt/Gulp/Broccoli) which concocts all or most .CSS into one file, so you don't need to do that for them.
  • inject CSS as part of the JS configuration

There are a few things you can do to help your users, so the main skel.css can be on CDN, without inducing configuring CSS:

  • Give instructions about how they add resets & configuration in their project. (easy)
  • provide a build script tool or instructions how to configure their build tool (medium)
  • online built tool like Bootstrap's

@ajlkn
Copy link
Owner

ajlkn commented Mar 30, 2014

I'll look into this. Thanks for the feedback.

@ajlkn ajlkn closed this as completed Mar 30, 2014
@tomByrer
Copy link
Author

Welcome. Sorry I made you drink from the firehose ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants