Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish releases (git tag) #19

Closed
martinhpedersen opened this issue Aug 21, 2022 · 2 comments
Closed

Publish releases (git tag) #19

martinhpedersen opened this issue Aug 21, 2022 · 2 comments

Comments

@martinhpedersen
Copy link
Contributor

Since we're now "in production" with this package as of Pat v0.13.0, it would be great to start publishing the module by tagging versions as per semantic versioning.

I would suggest starting at v1.0.0 for the current master HEAD (0b0963c).

https://go.dev/blog/publishing-go-modules
https://semver.org/

@n8jja
Copy link
Owner

n8jja commented Nov 8, 2022

@martinhpedersen - repository has been tagged as v1.0.0.

@n8jja n8jja closed this as completed Nov 8, 2022
@martinhpedersen
Copy link
Contributor Author

That didn't work as expected unfortunately 😞

The problem is that go.mod is not located at the root of the repo, making go mod unable to use the tag as the versioning for the sub-moduel vara.

We had the same problem with ptc-go. The solution was to move go.mod and go.sum to the root of the repo and renaming the go module name. I'll submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants