-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(Spreadsheet File Node): Improve CSV parsing (#7448)
This adds support for 1. custom delimiters 2. reading offsets to avoid having to read a large CSV all at once 3. excluding byte-order-mark NODE-861 #7443
- Loading branch information
Showing
6 changed files
with
273 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
a,b,c | ||
1,2,3 |
155 changes: 155 additions & 0 deletions
155
packages/nodes-base/nodes/SpreadsheetFile/test/workflow.bom.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,155 @@ | ||
{ | ||
"nodes": [ | ||
{ | ||
"parameters": {}, | ||
"id": "40bf604f-19f9-43e7-8bbb-74c36925f154", | ||
"name": "When clicking \"Execute Workflow\"", | ||
"type": "n8n-nodes-base.manualTrigger", | ||
"typeVersion": 1, | ||
"position": [ | ||
-320, | ||
1040 | ||
] | ||
}, | ||
{ | ||
"parameters": { | ||
"fileSelector": "bom.csv" | ||
}, | ||
"id": "623ea890-8882-4273-973e-834652d823b5", | ||
"name": "Read Binary File", | ||
"type": "n8n-nodes-base.readBinaryFiles", | ||
"typeVersion": 1, | ||
"position": [ | ||
-100, | ||
1040 | ||
] | ||
}, | ||
{ | ||
"parameters": { | ||
"fileFormat": "csv", | ||
"options": { | ||
"enableBOM": true | ||
} | ||
}, | ||
"id": "c8cca5fb-e119-4ca1-a597-4f051a7f64ea", | ||
"name": "Exclude BOM", | ||
"type": "n8n-nodes-base.spreadsheetFile", | ||
"typeVersion": 2, | ||
"position": [ | ||
120, | ||
960 | ||
] | ||
}, | ||
{ | ||
"parameters": { | ||
"fileFormat": "csv", | ||
"options": { | ||
"enableBOM": false | ||
} | ||
}, | ||
"id": "56ec11dc-966b-4d06-b8c0-61475b30333d", | ||
"name": "Include BOM", | ||
"type": "n8n-nodes-base.spreadsheetFile", | ||
"typeVersion": 2, | ||
"position": [ | ||
120, | ||
1180 | ||
] | ||
}, | ||
{ | ||
"parameters": { | ||
"fields": { | ||
"values": [ | ||
{ | ||
"name": "X", | ||
"stringValue": "={{ $json.a }}" | ||
} | ||
] | ||
}, | ||
"include": "none", | ||
"options": {} | ||
}, | ||
"id": "6f6bccf2-d674-4774-9df9-6f6fd893bace", | ||
"name": "Edit with BOM excluded", | ||
"type": "n8n-nodes-base.set", | ||
"typeVersion": 3.2, | ||
"position": [ | ||
320, | ||
960 | ||
] | ||
}, | ||
{ | ||
"parameters": { | ||
"fields": { | ||
"values": [ | ||
{ | ||
"name": "X", | ||
"stringValue": "={{ $json.a }}" | ||
} | ||
] | ||
}, | ||
"include": "none", | ||
"options": {} | ||
}, | ||
"id": "27ca5cde-19cb-4bf2-9ab4-7f7e77ad01bd", | ||
"name": "Edit with BOM included", | ||
"type": "n8n-nodes-base.set", | ||
"typeVersion": 3.2, | ||
"position": [ | ||
320, | ||
1180 | ||
] | ||
} | ||
], | ||
"connections": { | ||
"When clicking \"Execute Workflow\"": { | ||
"main": [ | ||
[ | ||
{ | ||
"node": "Read Binary File", | ||
"type": "main", | ||
"index": 0 | ||
} | ||
] | ||
] | ||
}, | ||
"Exclude BOM": { | ||
"main": [ | ||
[ | ||
{ | ||
"node": "Edit with BOM excluded", | ||
"type": "main", | ||
"index": 0 | ||
} | ||
] | ||
] | ||
}, | ||
"Include BOM": { | ||
"main": [ | ||
[ | ||
{ | ||
"node": "Edit with BOM included", | ||
"type": "main", | ||
"index": 0 | ||
} | ||
] | ||
] | ||
}, | ||
"Read Binary File": { | ||
"main": [ | ||
[ | ||
{ | ||
"node": "Exclude BOM", | ||
"type": "main", | ||
"index": 0 | ||
}, | ||
{ | ||
"node": "Include BOM", | ||
"type": "main", | ||
"index": 0 | ||
} | ||
] | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters