Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Hubspot Node): enable hubspot credentials for http predefined types #3686

Merged
merged 4 commits into from
Oct 17, 2022
Merged

feat(Hubspot Node): enable hubspot credentials for http predefined types #3686

merged 4 commits into from
Oct 17, 2022

Conversation

vcrwr
Copy link
Contributor

@vcrwr vcrwr commented Jul 9, 2022

Changed Hubspot ApiKey and AppToken credentials to be supported as httpRequest Node "Predefined Credential Type".

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Jul 9, 2022
@vcrwr
Copy link
Contributor Author

vcrwr commented Sep 26, 2022

With the deprecation of Hubspot APIkeys, AppToken are getting important very soon. Would be great if you could review and accept the PR. :)

@Joffcom
Copy link
Member

Joffcom commented Oct 6, 2022

Hey @vcrwr,

I am not sure how I missed this one but I will get this one sorted later today 👍🏻

@Joffcom
Copy link
Member

Joffcom commented Oct 6, 2022

Hey @vcrwr,

There are a couple of changes I want to make but it won't let me add to the PR, I am not sure why though. If I pop them into the PR as nodes do you fancy doing them unless you have an option to enable write access on the PR.

@vcrwr
Copy link
Contributor Author

vcrwr commented Oct 10, 2022

According to the documentation, there should be a "Allow edits from maintainers" option in the PR for me. But there is not. :(

Of course I'm happy to apply your changes.

Joffcom
Joffcom requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes below, Thanks again for this one.

packages/nodes-base/credentials/HubspotApi.credentials.ts Show resolved Hide resolved
packages/nodes-base/credentials/HubspotAppToken.credentials.ts Show resolved Hide resolved
packages/nodes-base/nodes/Hubspot/GenericFunctions.ts Outdated Show resolved Hide resolved
@vcrwr vcrwr force-pushed the hubspot-predefined-credentials branch from 0a3a572 to d663527 Compare October 13, 2022 07:11
@vcrwr vcrwr changed the title (mod) enable hubspot credentials for http predefined types feat: enable hubspot credentials for http predefined types Oct 13, 2022
@vcrwr
Copy link
Contributor Author

vcrwr commented Oct 13, 2022

@Joffcom thanks for the review. I added the test requests and changed the code as recommended.

@Joffcom
Copy link
Member

Joffcom commented Oct 13, 2022

Hey @vcrwr,

Looks good, I will give it another quick test shortly just to make sure it all works then we can get it merged in 👍🏻

@Joffcom Joffcom changed the title feat: enable hubspot credentials for http predefined types feat(Hubspot Node): enable hubspot credentials for http predefined types Oct 17, 2022
@Joffcom Joffcom merged commit b5c40e6 into n8n-io:master Oct 17, 2022
@Joffcom
Copy link
Member

Joffcom commented Oct 17, 2022

Thanks for the PR @vcrwr this is now merged 🙌🏻

@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 17, 2022
@janober
Copy link
Member

janober commented Oct 21, 2022

Got released with n8n@0.199.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 21, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@vcrwr
feat(Hubspot Node): enable hubspot credentials for http predefined ty…
2340f5a 
…pes (n8n-io#3686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcrwr @Joffcom @janober