fix(cli): Fix issue with n8n crashing when error in poll method #4008
Conversation
RicardoE105
changed the title
n8n-assistant
bot
added
core
| }; | ||
|
|
||
| const execution = ResponseHelper.flattenExecutionData(fullExecutionData); | ||
|
|
There was a problem hiding this comment.
@krynble Should we check the workflow settings to check whether save error execution is enabled
before saving the error execution?
There was a problem hiding this comment.
Hum that's a good point. Now thinking about alternatives, we have what we call "Activation errors".
You can see in the packages/cli/src/ActiveWorkflowRunner.ts file specifically inside add function, we try to activate a workflow and if it fails, we deactivate it and add an error the user can see when opening the workflows list.
Instead of generating a failed execution, what if we deactivate the workflow and display this error?
On the other hand, this is bad because we'll deactivate the workflow even if the service is temporarily down and a next poll request would work just fine.
Maybe the current approach you implemented is best for debuggability and failed executions are saved by default, so we should check this flag, yes, and only save if it's checked.
We just need to make sure that WorkflowData that we received was actually populated with this, because I've seen situations where this did not happen.
There was a problem hiding this comment.
Yeah, I think this is a much better approach. For example, in the Airtable case, the issue is generated by changing the trigger column in Airtable (Workflow does not have to be touched). In case this happens, with this approach, the user will have an issue in the error tab or will be notified via the error workflow, then look at the error, and finally adjust in Airtable without having to touch the workflow. The other approach will be an extra step having to activate the workflow again, and if we do not save the execution plus they do not have an error workflow setup, they will never notice the error.
RicardoE105
changed the title
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
…io#4008) * 🐛 Fix issue with n8n crashing when error in poll method * Remove unnecessary imports and add async property * Remove unnecessary imports * ⚡ Move createErrorExecution to genericHelper * ⚡ Improvements Co-authored-by: Omar Ajoue <krynble@gmail.com>
N8N-4272