Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AWS credential testing issue #4107

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Sep 15, 2022

No description provided.

@krynble krynble added n8n team Authored by the n8n team Upcoming Release Will be part of the upcoming release node/issue Issue with a node labels Sep 15, 2022
@krynble krynble self-assigned this Sep 15, 2022
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@krynble krynble merged commit 5130529 into master Sep 15, 2022
@krynble krynble deleted the n8n-4636-node-issue-aws-credential-signing branch September 15, 2022 13:03
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with n8n@0.194.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@rhyswilliamsza
Copy link
Contributor

rhyswilliamsza commented Apr 27, 2023

Hey @krynble! :)

We're experiencing a bit of a performance issue when uploading large files via the AWS Node. Specifically, it appears that Object.keys(body) blows up a 60MB file into about 4GB of memory usage.

Could you perhaps point me in the direction of what this fixed for testing? I'm hoping to see if there a way to possibly achieve the same result by another means?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants