Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(editor): improve array intersection utility function #4503

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

cstuncsik
Copy link
Contributor

Tested with 3 versions of custom functions + lodash + Ramda
See the test results in the screenshot, it is worth having the one that can accept any number of arrays, it's just slightly slower than the other that can take only 2 args

image

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 1, 2022
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌 Also kudos for adding unit tests

@cstuncsik cstuncsik merged commit b0df810 into master Nov 2, 2022
@cstuncsik cstuncsik deleted the improve-array-intersection-utility-function branch November 2, 2022 14:03
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 2, 2022
@janober
Copy link
Member

janober commented Nov 2, 2022

Got released with n8n@0.201.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 2, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 4, 2022
* master:
  refactor(editor): Migrate part of the vuex store to pinia (#4484)
  fix(editor): fix themes the monaco editor (no-changelog) (#4521)
  refactor(editor): restrict mapping discoverability tooltip showing only on string input (#4496)
  📚 Remove entries from Changelog
  📚 Update CHANGELOG.md and main package.json to 0.201.0
  🔖 Release n8n@0.201.0
  ⬆️ Set n8n-core@0.141.0, n8n-editor-ui@0.167.0, n8n-nodes-base@0.199.0 and n8n-workflow@0.123.0 on n8n
  🔖 Release n8n-editor-ui@0.167.0
  ⬆️ Set n8n-design-system@0.41.0 and n8n-workflow@0.123.0 on n8n-editor-ui
  🔖 Release n8n-design-system@0.41.0
  🔖 Release n8n-nodes-base@0.199.0
  ⬆️ Set n8n-core@0.141.0 and n8n-workflow@0.123.0 on n8n-nodes-base
  🔖 Release n8n-node-dev@0.80.0
  ⬆️ Set n8n-core@0.141.0 and n8n-workflow@0.123.0 on n8n-node-dev
  🔖 Release n8n-core@0.141.0
  ⬆️ Set n8n-workflow@0.123.0 on n8n-core
  🔖 Release n8n-workflow@0.123.0
  fix(core): make `deepCopy` backward compatible (#4505)
  fix(editor): workflow settings link font size change (no-changelog) (#4511)
  perf(editor): improve array intersection utility function (#4503)

# Conflicts:
#	packages/editor-ui/src/App.vue
#	packages/editor-ui/src/components/ActivationModal.vue
#	packages/editor-ui/src/components/NDVDraggablePanels.vue
#	packages/editor-ui/src/components/NodeSettings.vue
#	packages/editor-ui/src/components/Sticky.vue
#	packages/editor-ui/src/components/mixins/workflowHelpers.ts
#	packages/editor-ui/src/constants.ts
#	packages/editor-ui/src/plugins/i18n/index.ts
#	packages/editor-ui/src/views/ChangePasswordView.vue
#	packages/editor-ui/src/views/NodeView.vue
#	packages/editor-ui/src/views/SignupView.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants