-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add license support to n8n #4566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this coming to life! 🙌
Please consider the changes I proposed.
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor suggestions.
return this.manager.hasFeatureEnabled(feature); | ||
} | ||
|
||
isSharingEnabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding the cloud-specific checks here? That way we could concentrate these special checks here and not have them scattered across the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which checks do you mean.. the cloud check we need is already here.. checking for config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait I get it.. you want to move config checks here.. not sure it makes sense.. I would have a separate module that manages features..
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
* feature/ad-ldap: (108 commits) 👕 Fix linting problem fix: Workflow activation should not crash if one of the credential is invalid (#4671) feat(core): Add license support to n8n (#4566) fix: Use the updated slots syntax in ResourceLocator (no-changelog) (#4663) fix: Community package uninstall button should show the confirmation modal (no-changelog) (#4668) fix: Fix broken n8n-info-tip slots (#4665) fix(editor): Table view column limit tooltip (#4655) ci: Block execution of `npm install` (no-changelog) (#4662) fix(editor): Prevent node-creator tabs from showing when toggled by CanvasAddButton (#4661) fix(Schedule Trigger Node): Fixes inconsitent behavior with cron and weekly intervals (#4558) fix(core): Fix for unused imports fix: Add temporary slot syntax lint exceptions (no-changelog) (#4652) fix(editor): Fix missing resource locator component (#4649) refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648) refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644) refactor: Migrate Vue slots to the new syntax (#4603) refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647) fix: Make users fakedoor route visible on cloud (#4645) 📚 Update CHANGELOG.md and main package.json to 0.203.1 🔖 Release n8n@0.203.1 ... # Conflicts: # packages/design-system/src/components/N8nFormInput/FormInput.vue # packages/design-system/src/components/N8nFormInputs/FormInputs.stories.js # packages/design-system/src/components/N8nFormInputs/FormInputs.vue # packages/design-system/src/types/form.ts
Got released with |
No description provided.