Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Ensure executions list is properly filtered for all users #4765

Merged
merged 9 commits into from
Nov 30, 2022
Merged

fix(core): Ensure executions list is properly filtered for all users #4765

merged 9 commits into from
Nov 30, 2022

Conversation

freyamade
Copy link
Contributor

No description provided.

@freyamade freyamade changed the title fix(core): ensure executions list is properly filtered for all users fix(core): Ensure executions list is properly filtered for all users Nov 29, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 29, 2022
krynble
krynble suggested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loved how neat and tidy the controllers are, nice job.

Code reusability is great too!

Minor console.log left and you can ignore the sharedWorkflowIds thing if you want, it's not major.

packages/cli/src/executions/executions.service.ts Outdated Show resolved Hide resolved
packages/cli/src/executions/executions.service.ts Outdated Show resolved Hide resolved
krynble
krynble approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freyamade freyamade marked this pull request as ready for review November 30, 2022 12:59
@freyamade freyamade merged commit ddf787c into master Nov 30, 2022
@freyamade freyamade deleted the mon-1-can-access-executions-of-all-workflows branch November 30, 2022 13:00
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 30, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 30, 2022
@MiloradFilipovic
Merge branch 'master' into feature/undo-redo
2f724da 
* master:
  fix(core): Ensure executions list is properly filtered for all users (#4765)
  ci: Fix linting issues on master (no-changelog) (#4768)
  fix(Microsoft Outlook Node): Fix binary attachment upload (#4766)
@janober
Copy link
Member

janober commented Dec 2, 2022

Got released with n8n@0.205.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freyamade @janober @krynble