feat(Postmark Trigger Node): Update credentials so they can be used in the HTTP Request Node #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkn
changed the title
bramkn
changed the title
bramkn
changed the title
|
Hey @bramkn, Thanks for the PR, I am just going to check this one now quickly before signing off for the day. |
n8n-assistant
bot
added
community
|
Hey @bramkn, I have given the trigger node a test and used the credential in the HTTP request node and all looks to be good. Thanks for the time you spent on this PR, I will get it merged now. |
Joffcom
changed the title
Joffcom
approved these changes
Dec 1, 2022
|
Thanks again @bramkn, This has now been merged and will be available in the next release. |
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 1, 2022
* master: feat(Postmark Trigger Node): Update credentials so they can be used with the HTTP Request Node (#4790) fix(editor): Remove unnecessary closing tag in CanvasControls (no-changelog) (#4792) feat(Facebook Graph API Node): Update to support api version 15 (#4791) fix(Pipedrive Node): Resolve properties not working fix(editor): Remove excess `isReadOnly` prop (no-changelog) (#4786) fix(core): OAuth2 scope saved to DB fix feat(editor): Overhaul expression editor modal (#4631) test(editor): Intercept credentials save and test request and wait for them in e2e test (#4778) fix(Google Sheets Node): Fix for append operation if no empty rows in sheet
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new way of doing credentials so they also show up in HTTP request node.
As we only have a trigger node now for postmark, this helps us a lot adding API requests through the HTTP request without the need to setup the credentials 2x.