Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Persist CurrentAuthenticationMethod setting change #5762

Merged

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 23, 2023
@flipswitchingmonkey flipswitchingmonkey merged commit 4498c60 into master Mar 23, 2023
9 of 10 checks passed
@flipswitchingmonkey flipswitchingmonkey deleted the pay-314-when-toggling-authenticationmethod-make branch March 23, 2023 14:13
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 23, 2023
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
* master:
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
…res-node-resorce-mapper

* feature/resource-mapping-component:
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
MiloradFilipovic added a commit that referenced this pull request Mar 24, 2023
* master: (80 commits)
  feat: Execution custom data saving and filtering (#5496)
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  fix(editor): Use credentials when fetching node and credential types (#5760)
  fix: Update Posthog no-capture (#5693)
  fix(core): Return SAML service provider urls with config (#5759)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  feat(editor): Fix ResourceLocator dropdown style (#5714)
  feat(Filter Node): New node
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742)
  feat(core): Make OAuth2 error handling consistent with success handling (#5555)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  ...
@janober
Copy link
Member

janober commented Mar 30, 2023

Got released with n8n@0.222.0

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
…#5762)

* limit user invites when saml is enabled

* persist CurrentAuthenticationMethod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants