feat(core): Make OAuth2 error handling consistent with success handling #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
netroy
reviewed
Feb 23, 2023
n8n-assistant
bot
added
community
netroy
force-pushed
the
oAuth_event_improvement_update
branch
from
12495e6
to
b21f9c4
Compare
netroy
changed the title
netroy
changed the title
netroy
force-pushed
the
oAuth_event_improvement_update
branch
2 times, most recently
from
c17f1a3
to
9369517
Compare
netroy
changed the title
netroy
force-pushed
the
oAuth_event_improvement_update
branch
from
9369517
to
89cbc6d
Compare
netroy
force-pushed
the
oAuth_event_improvement_update
branch
from
89cbc6d
to
f40629d
Compare
krynble
previously requested changes
Mar 9, 2023
netroy
approved these changes
Mar 22, 2023
netroy
approved these changes
Mar 22, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5555 +/- ##
==========================================
+ Coverage 14.35% 14.37% +0.02%
==========================================
Files 2467 2467
Lines 112958 112960 +2
Branches 17567 17566 -1
==========================================
+ Hits 16211 16238 +27
+ Misses 96244 96220 -24
+ Partials 503 502 -1
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 23, 2023
…nd-foundations-sheets-node-api-endpoint * feature/resource-mapping-component: fix(editor): Use credentials when fetching node and credential types (#5760) fix: Update Posthog no-capture (#5693) fix(core): Return SAML service provider urls with config (#5759) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) feat(editor): Fix ResourceLocator dropdown style (#5714) feat(Filter Node): New node fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742) feat(core): Make OAuth2 error handling consistent with success handling (#5555) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) ci: Upgrade sanitize-html from 2.9.0 to 2.10.0 (#5744) fix(core): Remove circular refs from Code and push msg (#5741) fix(HTTP Request Node): Add streaming to binary response (#5701) fix(core): Force-upgrade `http-cache-semantics` to address CVE-2022-25881 (#5733) fix(core): Force-upgrade `decode-uri-component` to address CVE-2022-38900 (#5734)
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 24, 2023
* master: (80 commits) feat: Execution custom data saving and filtering (#5496) ci: Fix saml.api.test.ts (no-changelog) (#5764) docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763) 🚀 Release 0.221.0 (#5726) fix(core): Persist CurrentAuthenticationMethod setting change (#5762) feat(core): Limit user invites when SAML is enabled (#5761) fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) fix(editor): Use credentials when fetching node and credential types (#5760) fix: Update Posthog no-capture (#5693) fix(core): Return SAML service provider urls with config (#5759) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) feat(editor): Fix ResourceLocator dropdown style (#5714) feat(Filter Node): New node fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742) feat(core): Make OAuth2 error handling consistent with success handling (#5555) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) ...
|
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…ng (n8n-io#5555) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):